Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LinuxMakeGNU_OpenBLAS_x86 step in CI #3024

Merged
merged 12 commits into from
Dec 19, 2024

Conversation

Vika-F
Copy link
Contributor

@Vika-F Vika-F commented Dec 13, 2024

Disabling the step to get rid of illegal instructions failures and save the CI time.


PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.

@Vika-F Vika-F added the infra label Dec 16, 2024
@Vika-F Vika-F marked this pull request as ready for review December 16, 2024 13:12
@Vika-F Vika-F requested review from david-cortes-intel and removed request for Alexsandruss December 16, 2024 13:13
@david-cortes-intel
Copy link
Contributor

The error shown in the logs is really curious:

collect2: fatal error: ld terminated with signal 11 [Segmentation fault], core dumped

... that is, the linker from GNU is segfaulting when it tries to do its jobs, which is not supposed to happen.

Looks like we could just revert to building from source now.

@david-cortes-intel
Copy link
Contributor

The error shown in the logs is really curious:

collect2: fatal error: ld terminated with signal 11 [Segmentation fault], core dumped

... that is, the linker from GNU is segfaulting when it tries to do its jobs, which is not supposed to happen.

Looks like we could just revert to building from source now.

I am guessing that a potential reason could be that it is looking at files from the wrong platform, since the files contain also files for windows, but nevertheless, reverting to source builds should suffice for our CI purposes.

@napetrov
Copy link
Contributor

@rakshithgb-fujitsu FYI

On change itself - i think we don't need x86 openblas variant at all and just keep openblas ARM variant?

@rakshithgb-fujitsu
Copy link
Contributor

@rakshithgb-fujitsu FYI

On change itself - i think we don't need x86 openblas variant at all and just keep openblas ARM variant?

Yeah I agree on this. Reduces the load on CI as well.

@Vika-F Vika-F changed the title Change openBLAS build on x86_64 to fix illegal instructions Disable LinuxMakeGNU_OpenBLAS_x86 step in CI Dec 18, 2024
Copy link
Contributor

@david-cortes-intel david-cortes-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for CI results for the other openblas jobs.

@Vika-F Vika-F merged commit 71f30d6 into uxlfoundation:main Dec 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants