-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable LinuxMakeGNU_OpenBLAS_x86 step in CI #3024
Conversation
The error shown in the logs is really curious:
... that is, the linker from GNU is segfaulting when it tries to do its jobs, which is not supposed to happen. Looks like we could just revert to building from source now. |
I am guessing that a potential reason could be that it is looking at files from the wrong platform, since the files contain also files for windows, but nevertheless, reverting to source builds should suffice for our CI purposes. |
On change itself - i think we don't need x86 openblas variant at all and just keep openblas ARM variant? |
Yeah I agree on this. Reduces the load on CI as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait for CI results for the other openblas jobs.
Disabling the step to get rid of illegal instructions failures and save the CI time.
PR completeness and readability
Testing