Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: adding -fsycl-max-parallel-link-jobs in bazel #2943

Merged
merged 2 commits into from
Oct 10, 2024
Merged

feature: adding -fsycl-max-parallel-link-jobs in bazel #2943

merged 2 commits into from
Oct 10, 2024

Conversation

Alexandr-Solovev
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev commented Oct 9, 2024 •
edited
Loading

Description

Adding linking flag to improve linking of onedal_sycl lib in oneDAL(bazel)

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

Time of linking has been reduced from 120 seconds to 56 seconds with these changes. In case if machine has > 1 proc, it will provide speedup.

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

1 similar comment
@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

Vika-F
Vika-F approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Vika-F Vika-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@Alexandr-Solovev Alexandr-Solovev merged commit 4be2efd into uxlfoundation:main Oct 10, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vika-F Vika-F Vika-F approved these changes

@homksei homksei Awaiting requested review from homksei homksei is a code owner

@ethanglaser ethanglaser Awaiting requested review from ethanglaser ethanglaser is a code owner

@david-cortes-intel david-cortes-intel Awaiting requested review from david-cortes-intel

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@napetrov napetrov Awaiting requested review from napetrov napetrov is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 is a code owner

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexandr-Solovev @Vika-F