Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] correct Nightly-build, clean up ci files. #2920

Merged
merged 30 commits into from
Sep 30, 2024

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Sep 27, 2024

Description

Generally hard-coding complete directories in a CI runner is a no-no.
OpenCL runtime is necessary for windows dpc testing in sklearnex
clean up windows_build.bat and add alternate install directory
remove unnecessary files which have been duplicated
create an environment variable to minimize maintenance

@icfaust icfaust changed the title Dev/ci fixes [fix] correct Nightly-build, clean up ci files. Sep 27, 2024
@icfaust icfaust added the infra label Sep 27, 2024
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this pr! Btw, what do you think about renaming install_windows script, due to in real it install windows oneapi toolkit

.ci/scripts/install_windows.bat Show resolved Hide resolved
.github/workflows/nightly-build.yml Outdated Show resolved Hide resolved
.github/workflows/nightly-build.yml Outdated Show resolved Hide resolved
.github/workflows/nightly-build.yml Show resolved Hide resolved
@icfaust
Copy link
Contributor Author

icfaust commented Sep 27, 2024

/azp run CI

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@icfaust
Copy link
Contributor Author

icfaust commented Sep 27, 2024

/intelci: run

@icfaust
Copy link
Contributor Author

icfaust commented Sep 27, 2024

issues in docker images solved in #2922

@icfaust
Copy link
Contributor Author

icfaust commented Sep 27, 2024

Example of the Nightly-build which is successful https://github.com/icfaust/oneDAL/actions/runs/11072698466

Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!

@icfaust icfaust merged commit 76d0a1d into uxlfoundation:main Sep 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants