-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] correct Nightly-build, clean up ci files. #2920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this pr! Btw, what do you think about renaming install_windows script, due to in real it install windows oneapi toolkit
/azp run CI |
Azure Pipelines failed to run 1 pipeline(s). |
/intelci: run |
issues in docker images solved in #2922 |
Example of the Nightly-build which is successful https://github.com/icfaust/oneDAL/actions/runs/11072698466 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job!
Description
Generally hard-coding complete directories in a CI runner is a no-no.
OpenCL runtime is necessary for windows dpc testing in sklearnex
clean up windows_build.bat and add alternate install directory
remove unnecessary files which have been duplicated
create an environment variable to minimize maintenance