feature: adding blocking in a table convert function #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
Alexandr-Solovev
changed the title
|
/intelci: run |
Alexandr-Solovev
requested review from
Alexsandruss,
samir-nasibli and
KulikovNikita
as code owners
Alexandr-Solovev
requested review from
ethanglaser,
inteldimitrius and
avolkov-intel
Alexandr-Solovev
changed the title
|
/intelci: run |
|
/intelci: run |
Comment on lines
+23
to
+26
| std::int64_t propose_block_size(const sycl::queue& q, const std::int64_t r) { | ||
| constexpr std::int64_t fsize = sizeof(Float); | ||
| return 0x10000l * (8 / fsize); | ||
| } |
There was a problem hiding this comment.
Can it be exposed to an optimization library?
There was a problem hiding this comment.
I think its better to do it in another pr, due to we have a lot of local propose_block_size functions, and some of them are not aligned
|
/intelci: run |
ethanglaser
reviewed
Jan 9, 2024
Comment on lines
+110
to
+112
| const byte_t* const gathered_byte = | ||
| reinterpret_cast<const byte_t*>(gathered_device_unique.get()); | ||
| byte_t* const dst_byte = reinterpret_cast<byte_t*>(dst_device); |
There was a problem hiding this comment.
why is 110 const byte_t* and 112 byte_t* const?
There was a problem hiding this comment.
One line is source, and other one is a consumer aka destination)
|
/intelci: run |
|
Have these been changes been tested with the original spark issue? |
it was exactly tested with the spark issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Its feature for adding support of extremely big datasets in all algorithms