Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneMKL] Rename oneMKL Interface project #596

Merged
merged 18 commits into from
Dec 3, 2024

Conversation

s-Nick
Copy link
Contributor

@s-Nick s-Nick commented Oct 17, 2024

This PR address RFC #580.
It performs all the changes to namespace, name and file name requested in the issue.

EDIT:
For completeness, I attach a zip of the html version with changes
oneMath_html.zip

@s-Nick s-Nick requested a review from Rbiessy October 17, 2024 12:28
@Rbiessy Rbiessy requested a review from a team October 17, 2024 13:10
@s-Nick
Copy link
Contributor Author

s-Nick commented Oct 22, 2024

Hi @rscohn2, these changes are failing pre-commit checks due to two .jpg files. What should I do about it?

@rscohn2
Copy link
Member

rscohn2 commented Oct 22, 2024

Hi @rscohn2, these changes are failing pre-commit checks due to two .jpg files. What should I do about it?

Add it here: https://github.com/uxlfoundation/oneAPI-spec/blob/main/.reuse/dep5

s-Nick added 13 commits October 23, 2024 17:35
- Move source/elements/oneMKL to source/elements/oneMath
- Rename files using "mkl" or "onemkl" to "onemath"
- Rename occurrences of "oneMKL" and "onemkl" to "oneMath" and "onemath"
  respectively

Signed-off-by: nscipione <[email protected]>
- Rename the namespace oneapi::mkl to oneapi::math and references to
  the folder oneapi/mkl to oneapi/math

Signed-off-by: nscipione <[email protected]>
- Rename remaining occurrences of "mkl" to "onemath"

Signed-off-by: nscipione <[email protected]>
Fix table format

Signed-off-by: nscipione <[email protected]>
Replace wrong usage of "onemath" as namespace in favor of the correct
"math"

Signed-off-by: nscipione <[email protected]>
Set full name to "oneAPI Math Library" and update reference to it

Signed-off-by: nscipione <[email protected]>
Rename macros for domain and for version

Signed-off-by: nscipione <[email protected]>
@s-Nick s-Nick force-pushed the onemkl_to_onemath branch from 1e339a0 to c3301d5 Compare October 24, 2024 09:25
Copy link
Contributor

@Rbiessy Rbiessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!
For future reference I am also adding the link to the main RFC: uxlfoundation/oneMath#564

Copy link

@anantsrivastava30 anantsrivastava30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed fo FFT and approved.

Copy link
Contributor

@spencerpatty spencerpatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the architecture + appendix + domains/spblas sections and approve of these changes

@Rbiessy
Copy link
Contributor

Rbiessy commented Nov 26, 2024

@sknepper I see you have approved the renaming of the implementation but not this specification PR. Just pinging you here in case one of the domain owners of lapack want to approve this PR before November 29.

Add `const` to dependency where needed

Signed-off-by: nscipione <[email protected]>
Copy link
Contributor

@sknepper sknepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor comment - great work!!


Acknowledgment
---------------
The oneMKL `Technical Advisory Board <https://github.com/oneapi-src/oneAPI-tab>`__ members
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the oneMKL TAB was the precursor to the Math SIG, perhaps this would be better phrased as:

The Math Special Interest Group <https://github.com/uxlfoundation/foundation/tree/main/math>__ members ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review @sknepper
I updated it in ddfe85b

@Rbiessy Rbiessy merged commit 1aabfdd into uxlfoundation:main Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants