-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneMKL] Rename oneMKL Interface project #596
Conversation
source/elements/oneMath/source/domains/blas/blas-like-extensions.rst
Outdated
Show resolved
Hide resolved
Hi @rscohn2, these changes are failing |
Add it here: https://github.com/uxlfoundation/oneAPI-spec/blob/main/.reuse/dep5 |
- Move source/elements/oneMKL to source/elements/oneMath - Rename files using "mkl" or "onemkl" to "onemath" - Rename occurrences of "oneMKL" and "onemkl" to "oneMath" and "onemath" respectively Signed-off-by: nscipione <[email protected]>
- Rename the namespace oneapi::mkl to oneapi::math and references to the folder oneapi/mkl to oneapi/math Signed-off-by: nscipione <[email protected]>
- Rename remaining occurrences of "mkl" to "onemath" Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Fix table format Signed-off-by: nscipione <[email protected]>
Replace wrong usage of "onemath" as namespace in favor of the correct "math" Signed-off-by: nscipione <[email protected]>
Set full name to "oneAPI Math Library" and update reference to it Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Rename macros for domain and for version Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
Signed-off-by: nscipione <[email protected]>
1e339a0
to
c3301d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me!
For future reference I am also adding the link to the main RFC: uxlfoundation/oneMath#564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed fo FFT and approved.
source/elements/oneMath/source/architecture/execution_model.inc.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the architecture + appendix + domains/spblas sections and approve of these changes
@sknepper I see you have approved the renaming of the implementation but not this specification PR. Just pinging you here in case one of the domain owners of lapack want to approve this PR before November 29. |
Add `const` to dependency where needed Signed-off-by: nscipione <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One minor comment - great work!!
|
||
Acknowledgment | ||
--------------- | ||
The oneMKL `Technical Advisory Board <https://github.com/oneapi-src/oneAPI-tab>`__ members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the oneMKL TAB was the precursor to the Math SIG, perhaps this would be better phrased as:
The Math Special Interest Group <https://github.com/uxlfoundation/foundation/tree/main/math>
__ members ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: nscipione <[email protected]>
This PR address RFC #580.
It performs all the changes to namespace, name and file name requested in the issue.
EDIT:
For completeness, I attach a zip of the html version with changes
oneMath_html.zip