Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "TN-3324 robust handling of unsortable patient list attributes" #4417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pbugni
Copy link
Collaborator

@pbugni pbugni commented Oct 24, 2024

Reverts #4414

Wrong target. Forgot to change base after we decided this didn't need to be a hotfix.

@pep8speaks
Copy link

Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 40:101: E501 line too long (144 > 100 characters)
Line 41:101: E501 line too long (144 > 100 characters)
Line 50:101: E501 line too long (140 > 100 characters)
Line 60:101: E501 line too long (150 > 100 characters)
Line 61:101: E501 line too long (166 > 100 characters)

@pbugni
Copy link
Collaborator Author

pbugni commented Oct 24, 2024

@achen2401 can you review these changes.

I unintentionally merged this into master, as I'd opened the PR when I thought we'd hotfix the preferences issue. The majority of changes come from cleaning up broken test issues that came up out of nowhere.

I ask, as I see additional front end files I didn't have in my PR, so I'm wondering if those should be included in this attempt to roll master back to current prod?

Copy link
Contributor

@achen2401 achen2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbugni Can you rebase this against the develop branch? I see that some of the frontend changes I made aren’t there or reverted.

Copy link
Contributor

@achen2401 achen2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbugni please ignore my previous comment. I see this is reverting the commit from the master branch. I believe the frontend changes I made were correctly committed to the develop branch (they aren’t in the master branch yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants