Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email validation #335

Closed
wants to merge 1 commit into from
Closed

Fix email validation #335

wants to merge 1 commit into from

Conversation

bessone
Copy link

@bessone bessone commented Nov 10, 2020

1. Why is this change necessary?

Email validation uses a regex that doesn't accept the latest TLDs, such as .support. The TLD limit is 4 characters

2. What does this change do, exactly?

The code modification replaces the regex with a more complete and recent one, to try to use a standard, I used the one used by the HTML standard for validating inputs in HTML5 https://html.spec.whatwg.org/multipage/input.html#e-mail-state-(type%3Demail)

3. Please link to the relevant issues (if any).

#334

@papnoisanjeev
Copy link
Contributor

@bessone

Thanks for your contribution for email validation regex update !!

As your core bundle is not updated there was several update on this so before making any pull request make sure your bundle is up-to-date.

For now we have updated your suggested email validation regex in our master branch in all other files as well.
You can check here.

You can close this pull request now.

@bessone
Copy link
Author

bessone commented Nov 12, 2020

Thanks @papnoisanjeev ! I'm just a little sad that my very small contribution doesn't officially appear on the project :'(

@papnoisanjeev
Copy link
Contributor

@bessone

We know as we didn't merge your request so your image will not add as a contributor for this project at this time.
But next time we will defiantly add your pull request and you will be added as a contributor for this project :)

Please keep in mind your repository (core-framework, mailbox-bundle etc) should be up-to-date with latest changes as with your current request some updates were missing so if we didn't merge your request.

For this you need to delete current repository and fork latest one (https://prnt.sc/vhsm2z) again before submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants