1.0 issue 240 #244
Merged
1.0 issue 240 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…framework into gitter-badger-gitter-badge
Updating Core-FW Repo
…name displayed was that of the current logged in agent, not the list of all agent, now I have made appropriate correction to the sql query inside user service to handle null value of last name for the agent.
akshaywebkul
pushed a commit
that referenced
this pull request
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#240
The previous P.R. contained an overseen error.
Even though the name of the agent was being displayed not-blank on a null last name, it was only displaying the name of the current logged-in user( agent), whereas it should have been displaying the list of agent names.
I have resolved the issue by fixing the sql query inside UserService.php, using:
" COALESCE(user.lastName, '') ".
Thus resolving the issue from the back-end directly.