-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement -noleaf
#414
Implement -noleaf
#414
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 65.55% 65.58% +0.03%
==========================================
Files 34 34
Lines 3942 3952 +10
Branches 902 904 +2
==========================================
+ Hits 2584 2592 +8
Misses 1002 1002
- Partials 356 358 +2 ☔ View full report in Codecov by Sentry. |
Commit 38322c0 has GNU testsuite comparison:
|
LGTM |
Commit e9fcdaf has GNU testsuite comparison:
|
Sound like a perfect idea, we cannot assume that every user will review the code to determine compatibility. |
We use the walkdir library for directory traversal in our codebase, and the current predicates are all secondary filtering on the results returned by walkdir. So I guess
-noleaf
will not bring any optimization (unlesswalkdir
includes this optimization, to be honest I don't know much aboutwalkdir
and didn't find any related functions in their documentation).The current code only contains compatibility code.
Closes #376