Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.toml: set "default-features = false" for onig #313

Merged

Conversation

cakebaker
Copy link
Contributor

This PR sets default-features = false for onig in Cargo.toml. Without this setting, I get the following error when trying to run cargo run --bin find find --help:

error: failed to run custom build command for `onig_sys v69.8.1`

Caused by:
  process didn't exit successfully: `/home/dho/projects/findutils/target/debug/build/onig_sys-0c27472ef7fa82d9/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=RUSTONIG_DYNAMIC_LIBONIG
  cargo:rerun-if-env-changed=RUSTONIG_STATIC_LIBONIG
  cargo:rerun-if-env-changed=RUSTONIG_SYSTEM_LIBONIG

  --- stderr
  thread 'main' panicked at /home/dho/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.60/src/fallback.rs:791:9:
  "OnigValue_struct_(unnamed_at_oniguruma/src/oniguruma_h_786_3)" is not a valid Ident
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae6143f) 59.37% compared to head (faf7358) 57.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   59.37%   57.00%   -2.37%     
==========================================
  Files          30       30              
  Lines        3655     3652       -3     
  Branches      872      873       +1     
==========================================
- Hits         2170     2082      -88     
- Misses       1173     1267      +94     
+ Partials      312      303       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 5265f4f into uutils:main Feb 20, 2024
12 of 13 checks passed
@cakebaker cakebaker deleted the set_default_features_false_for_onig branch February 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants