Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find: Use the uucore mode parsing implementation for -perm #154

Merged
merged 2 commits into from
Mar 25, 2022
Merged

find: Use the uucore mode parsing implementation for -perm #154

merged 2 commits into from
Mar 25, 2022

Conversation

tavianator
Copy link
Contributor

@tavianator tavianator commented Mar 16, 2022

Fixes #26.

@sylvestre
Copy link
Contributor

maybe there is already but would it be possible to have a test reproducing this previous error?
(integration non regression test)
thanks

@tavianator
Copy link
Contributor Author

Which previous error do you mean?

@sylvestre
Copy link
Contributor

this one:
#26 (comment)

@tavianator
Copy link
Contributor Author

Ah good point, I'll add those!

@sylvestre
Copy link
Contributor

Thanks :)

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #154 (0b23d9b) into main (4cd4e4f) will increase coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   53.51%   53.55%   +0.04%     
==========================================
  Files          28       28              
  Lines        4802     4748      -54     
  Branches     1573     1553      -20     
==========================================
- Hits         2570     2543      -27     
+ Misses       1674     1668       -6     
+ Partials      558      537      -21     
Impacted Files Coverage Δ
src/find/matchers/mod.rs 63.44% <ø> (ø)
src/find/matchers/perm.rs 62.50% <68.00%> (-5.39%) ⬇️
tests/find_cmd_tests.rs 83.76% <100.00%> (+0.77%) ⬆️
src/lib.rs 36.17% <0.00%> (ø)
src/xargs/mod.rs 80.31% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd4e4f...0b23d9b. Read the comment docs.

@sylvestre sylvestre merged commit fcb89d2 into uutils:main Mar 25, 2022
@tavianator tavianator deleted the perm-uucore branch March 25, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-perm doesn't accept some valid symbolic modes
2 participants