Add support for regex matching #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi64
force-pushed
the
regex
branch
6 times, most recently
from
a658bf6 to
996ddac
Compare
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
==========================================
- Coverage 49.80% 47.91% -1.90%
==========================================
Files 19 20 +1
Lines 2594 4097 +1503
Branches 702 1429 +727
==========================================
+ Hits 1292 1963 +671
- Misses 1046 1650 +604
- Partials 256 484 +228
Continue to review full report at Codecov.
|
|
Looks like CI is finally passing, you know it's a good day when you hit a bug in an unrelated crate due to compiler flags 😅 |
|
could you please rebase this patch to compare with the other testsuite? thanks |
This adds support for -regextype, -regex, and -iregex, using Oniguruma to implement support for the Emacs, grep, POSIX basic, and POSIX extended regex types. Signed-off-by: Ryan Gonzalez <[email protected]>
Depending on onig ends up requiring proc_macro2, but the version that was in the lockfile breaks the build if panic=abort is used (which is done for coverage checks). This was fixed in 1.0.30+ for Rust 1.57+, so update to that version. Signed-off-by: Ryan Gonzalez <[email protected]>
|
Done:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for -regextype, -regex, and -iregex, using Oniguruma
to implement support for the Emacs, grep, POSIX basic, and POSIX
extended regex types.
Signed-off-by: Ryan Gonzalez [email protected]
Meta note: I'm not sure if it would be preferred to have this behind a feature, since oniguruma is a C dependency, or if
regexshould be removed instead due to functionality overlap.