Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ls: when a file has capabilities (setcap), change the color #6987

Merged
merged 2 commits into from
Dec 22, 2024
Merged

ls: when a file has capabilities (setcap), change the color #6987

merged 2 commits into from
Dec 22, 2024

Conversation

sylvestre
Copy link
Contributor

Should fix tests/ls/capability.sh

@sylvestre sylvestre force-pushed the setcap branch 2 times, most recently from 40e5492 to 693f6a2 Compare December 21, 2024 20:23
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/capability is no longer failing!

@sylvestre sylvestre force-pushed the setcap branch 3 times, most recently from 928cea2 to 47c72e0 Compare December 21, 2024 22:14
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/capability is no longer failing!

@sylvestre sylvestre force-pushed the setcap branch 2 times, most recently from 4b1ac9c to e6e6367 Compare December 22, 2024 08:31
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/capability is no longer failing!

@sylvestre
Copy link
Contributor Author

for some reasons, it didn't mention no-cap.sh
2024-12-22T08:46:25.6573098Z PASS: tests/ls/no-cap.sh

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/no-cap is no longer SKIP! (might be PASS, ERROR or FAIL)
Congrats! The gnu test tests/ls/capability is no longer failing!

@sylvestre
Copy link
Contributor Author

I moved the GNU modification into a different PR:
#6988

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/capability is no longer failing!

@sylvestre
ls: when a file has capabilities (setcap), change the color
9a97c18 
Should fix tests/ls/capability.sh
@sylvestre
ls: Don't call the capabilites features of the system when passed an …
ffc6eb0 
…empty ca=

in LS_COLORS

In parallel, in the GNU test, adjust the GNU tests as we don't use libcap
but xattr instead.
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/no-cap is no longer SKIP! (might be PASS, ERROR or FAIL)
Congrats! The gnu test tests/ls/capability is no longer failing!

@cakebaker cakebaker merged commit d3db8dc into uutils:main Dec 22, 2024
62 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/ls/capability is no longer failing!

Great :)

@sylvestre sylvestre deleted the setcap branch December 22, 2024 18:45
@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker Awaiting requested review from cakebaker

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker