Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base32/base64: handle two corner cases #6906

Merged
merged 1 commit into from
Dec 9, 2024
Merged

base32/base64: handle two corner cases #6906

merged 1 commit into from
Dec 9, 2024

Conversation

sylvestre
Copy link
Contributor

  • no padding
  • --wrap 0

Should make base64.pl pass

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/basenc/base64 is no longer failing!

@sylvestre sylvestre force-pushed the base-wrap branch 2 times, most recently from 3dfabc4 to 226e4ce Compare December 2, 2024 21:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/basenc/base64 is no longer failing!

@sylvestre sylvestre force-pushed the base-wrap branch 3 times, most recently from 8aed070 to 468914f Compare December 3, 2024 21:17
@sylvestre sylvestre requested a review from cakebaker December 3, 2024 21:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/base64 is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre
base32/base64: handle two corner cases
93dfc93 
* no padding
* --wrap 0

+ remove property_tests.rs, we don't need such tests as the
code is already tests by test_base* (+ it is too dependant
on the code structure)

Should make base64.pl pass
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/base64 is no longer failing!

@cakebaker cakebaker merged commit 2a9e7c9 into uutils:main Dec 9, 2024
61 of 62 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/basenc/base64 is no longer failing!

Great, good job :)

@sylvestre sylvestre deleted the base-wrap branch December 9, 2024 15:28
@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker