Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

echo: handle multibyte escape sequences #6803

Merged
merged 10 commits into from
Oct 22, 2024
Merged

echo: handle multibyte escape sequences #6803

merged 10 commits into from
Oct 22, 2024

Conversation

andrewliebenow
Copy link
Contributor

Bug was reported, with root cause analysis, by kkew3 Added tests were derived from test cases provided by kkew3 See #6741

@andrewliebenow
echo: handle multibyte escape sequences
6d8a781 
Bug was reported, with root cause analysis, by kkew3
Added tests were derived from test cases provided by kkew3
See uutils#6741
@andrewliebenow
Use concrete type
5d9fa38
@andrewliebenow andrewliebenow mentioned this pull request Oct 20, 2024
Closed
@andrewliebenow andrewliebenow mentioned this pull request Oct 20, 2024
Open
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

sylvestre
sylvestre reviewed Oct 21, 2024
View reviewed changes
src/uu/echo/src/echo.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 21, 2024
View reviewed changes
src/uu/echo/src/echo.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 21, 2024
View reviewed changes
src/uu/echo/src/echo.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 21, 2024
View reviewed changes
src/uu/echo/src/echo.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 21, 2024
View reviewed changes
src/uu/echo/src/echo.rs Outdated Show resolved Hide resolved
cakebaker
cakebaker reviewed Oct 21, 2024
View reviewed changes
src/uu/echo/src/echo.rs Outdated Show resolved Hide resolved
@andrewliebenow
Copy link
Contributor Author

The octal/hexadecimal code ended up being a bit longer, but hopefully it's more clear now. Naming and other issues fixed.

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 66f11c4 into uutils:main Oct 22, 2024
67 of 68 checks passed
@cakebaker
Copy link
Contributor

Thanks!

@cakebaker cakebaker mentioned this pull request Oct 22, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

@cakebaker cakebaker cakebaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewliebenow @cakebaker @sylvestre