Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basenc: ignore Interrupted errors #6778

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

andrewliebenow
Copy link
Contributor

Mirror behavior of std::io::Read's read_to_end function (link): continue reading when errors with kind std::io::ErrorKind::Interrupted are encountered.

Also: clean up a few other things.

Copy link

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

@andrewliebenow andrewliebenow force-pushed the basenc-ignore-interrupted branch from f4599d0 to 4b11226 Compare October 20, 2024 14:55
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/tail/assert is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre force-pushed the basenc-ignore-interrupted branch from 4b11226 to b9f931f Compare November 16, 2024 19:17
@sylvestre
Copy link
Contributor

Do you know if it is possible to test this?

@sylvestre sylvestre force-pushed the basenc-ignore-interrupted branch from b9f931f to 1c24804 Compare December 2, 2024 09:03
Copy link

github-actions bot commented Dec 2, 2024

GNU testsuite comparison:

GNU test failed: tests/misc/usage_vs_getopt. tests/misc/usage_vs_getopt is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Mirror behavior of `std::io::Read`'s `read_to_end` function
([link][1]): continue reading when errors with kind
`std::io::ErrorKind::Interrupted` are encountered.

Also: clean up a few other things.

[1]: https://doc.rust-lang.org/std/io/trait.Read.html#method.read_to_end
@sylvestre sylvestre force-pushed the basenc-ignore-interrupted branch from 1c24804 to caf08dd Compare December 4, 2024 09:13
@sylvestre sylvestre merged commit d9ccbcd into uutils:main Dec 4, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants