Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail: use #[ignore] to disable tests #6388

Merged
merged 2 commits into from
May 9, 2024
Merged

tail: use #[ignore] to disable tests #6388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef7933
tail: use #[ignore] to disable tests
cakebaker May 9, 2024
0ad7389
tail: remove #[cfg(not(windows))] from const
cakebaker May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions tests/by-util/test_tail.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ const FOLLOW_NAME_SHORT_EXP: &str = "follow_name_short.expected";
#[allow(dead_code)]
const FOLLOW_NAME_EXP: &str = "follow_name.expected";

#[cfg(not(windows))]
const DEFAULT_SLEEP_INTERVAL_MILLIS: u64 = 1000;

// The binary integer "10000000" is *not* a valid UTF-8 encoding
Expand Down Expand Up @@ -84,7 +83,7 @@ fn test_stdin_explicit() {

#[test]
// FIXME: the -f test fails with: Assertion failed. Expected 'tail' to be running but exited with status=exit status: 0
#[cfg(disable_until_fixed)]
#[ignore = "disabled until fixed"]
#[cfg(not(target_vendor = "apple"))] // FIXME: for currently not working platforms
fn test_stdin_redirect_file() {
// $ echo foo > f
Expand Down Expand Up @@ -2596,7 +2595,7 @@ fn test_fifo() {

#[test]
#[cfg(unix)]
#[cfg(disable_until_fixed)]
#[ignore = "disabled until fixed"]
fn test_illegal_seek() {
// This is here for reference only.
// We don't call seek on fifos, so we don't hit this error case.
Expand Down Expand Up @@ -3434,7 +3433,7 @@ fn test_args_when_presume_input_pipe_given_input_is_file() {
}

#[test]
#[cfg(disable_until_fixed)]
#[ignore = "disabled until fixed"]
// FIXME: currently missing in the error message is the last line >>tail: no files remaining<<
fn test_when_follow_retry_given_redirected_stdin_from_directory_then_correct_error_message() {
let ts = TestScenario::new(util_name!());
Expand Down Expand Up @@ -3830,7 +3829,7 @@ fn test_when_argument_files_are_triple_combinations_of_fifo_pipe_and_regular_fil
// test system. However, this behavior shows up on the command line and, at the time of writing this
// description, with this test on macos and windows.
#[test]
#[cfg(disable_until_fixed)]
#[ignore = "disabled until fixed"]
fn test_when_follow_retry_then_initial_print_of_file_is_written_to_stdout() {
let scene = TestScenario::new(util_name!());
let at = &scene.fixtures;
Expand Down Expand Up @@ -4141,7 +4140,7 @@ fn test_args_when_settings_check_warnings_follow_indefinitely_then_no_warning()

/// The expected test outputs come from gnu's tail.
#[test]
#[cfg(disable_until_fixed)]
#[ignore = "disabled until fixed"]
fn test_follow_when_files_are_pointing_to_same_relative_file_and_data_is_appended() {
let scene = TestScenario::new(util_name!());
let at = &scene.fixtures;
Expand Down Expand Up @@ -4229,7 +4228,7 @@ fn test_follow_when_files_are_pointing_to_same_relative_file_and_data_is_appende

/// The expected test outputs come from gnu's tail.
#[test]
#[cfg(disable_until_fixed)]
#[ignore = "disabled until fixed"]
fn test_follow_when_files_are_pointing_to_same_relative_file_and_file_is_truncated() {
let scene = TestScenario::new(util_name!());
let at = &scene.fixtures;
Expand Down Expand Up @@ -4282,7 +4281,7 @@ fn test_follow_when_files_are_pointing_to_same_relative_file_and_file_is_truncat
/// The expected test outputs come from gnu's tail.
#[test]
#[cfg(unix)]
#[cfg(disable_until_fixed)]
#[ignore = "disabled until fixed"]
fn test_follow_when_file_and_symlink_are_pointing_to_same_file_and_append_data() {
let scene = TestScenario::new(util_name!());
let at = &scene.fixtures;
Expand Down
Loading