Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling compare_xattrs cp and mv related tests on OpenBSD #6368

Merged
merged 1 commit into from
May 9, 2024

Conversation

jadijadi
Copy link
Contributor

@jadijadi jadijadi commented May 6, 2024

The test_cp and test_mv have xattr related tests. They should be disabled on OpenBSD after commit 19d42c0 disabled the compare_xattrs function on OpenBSD.

Related to #6349
Fixes #6348

@BenWiederhake
Copy link
Collaborator

Back in #6349 I silently assumed that you re-ran the tests to verify that the function-removal does not have any knock-on-effects. Thanks for following up on it, though! Let's make uutils work perfectly. :)

@jadijadi
Copy link
Contributor Author

jadijadi commented May 6, 2024

Back in #6349 I silently assumed that you re-ran the tests to verify that the function-removal does not have any knock-on-effects. Thanks for following up on it, though! Let's make uutils work perfectly. :)

Right. My mistake. I ran tests before sending the PR but after the suggestion for the removal of the actual compare_xattrs I did it from my OpenBSD machine which does not have the git hooks for automatic tests. Had to push from my linux machine. Installing the hooks on OpenBSD machine to prevent this from happening again.

Copy link

github-actions bot commented May 6, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@cakebaker
Copy link
Contributor

Can you please run cargo fmt?

@jadijadi jadijadi force-pushed the remove-xattrs-tests branch from 51c89ec to dc37f89 Compare May 9, 2024 15:42
The test_cp and test_mv have xattr related tests. They should
be disabled on OpenBSD after commit 19d42c0 disabled the
compare_xattrs function on OpenBSD.

Fixes uutils#6348
@jadijadi jadijadi force-pushed the remove-xattrs-tests branch from dc37f89 to 8108d7a Compare May 9, 2024 15:43
@jadijadi
Copy link
Contributor Author

jadijadi commented May 9, 2024

Can you please run cargo fmt?

just did. and added tests and fmt to the hooks.

Copy link

github-actions bot commented May 9, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@BenWiederhake
Copy link
Collaborator

Remaining failures are #6275 and #6333 – I'll keep repeating this until we find someone who can fix that problem :)

@BenWiederhake BenWiederhake merged commit 9303f8e into uutils:main May 9, 2024
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests in tests/common/util.rs fails on OpenBSD 7.5
3 participants