Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

id: Handle repeated flags, recognize conflict between pretty-print and passwd file-entry #6288

Merged
merged 2 commits into from
Apr 29, 2024
Merged

id: Handle repeated flags, recognize conflict between pretty-print and passwd file-entry #6288

merged 2 commits into from
Apr 29, 2024

Conversation

BenWiederhake
Copy link
Collaborator

This PR fixes argument-parsing for id, in particular:

  • All arguments can now be repeated (this makes sense for all of them; I checked.)
  • -p and -P both take control of the output format, so it does not make sense to specify both of them.

This is work toward #5998.

@BenWiederhake
id: permit repeated flags
e978fe5
@BenWiederhake
id: mark passwd-format and pretty-print as conflicting
4f5a3b4 
These are non-sensical to combine, and didn't work reasonably anyway.
Also, passwd-formatting is our own extension, so there is no need for
compatibility anyway.
@BenWiederhake BenWiederhake mentioned this pull request Apr 28, 2024
Open
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@BenWiederhake
Copy link
Collaborator Author

Only CI failure is a known flake: #6275

@cakebaker cakebaker changed the title id: Handle repeated flags, recognize confliect between pretty-print and passwd file-entry id: Handle repeated flags, recognize conflict between pretty-print and passwd file-entry Apr 29, 2024
@cakebaker cakebaker merged commit 5fbc588 into uutils:main Apr 29, 2024
67 of 68 checks passed
@cakebaker
Copy link
Contributor

Thanks!

@BenWiederhake BenWiederhake deleted the dev-id-flag-repeat branch April 29, 2024 12:32
@BrewTestBot BrewTestBot mentioned this pull request Jun 23, 2024
Merged
@moonfruit moonfruit mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWiederhake @cakebaker