-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kill: support multiple signals for --list #6210
Conversation
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, especially good catch regarding the continue-on-error behavior!
Please also write tests so that we don't regress in the future. (Eventually the argument parser will be rewritten, and it would be nice to know for sure that features like this didn't accidentally break.)
I have added necessary tests for multiple signals as well as to test for vertical list #6213 |
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loogs good, and thank you for adding the test for vertical signals!
Issue #6202
Changes
Multiple signal input support for --list command
Don't terminate and display error inline when signal is not recognized