Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shuf: Do not read input when -n0 is given #5990

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

BenWiederhake
Copy link
Collaborator

This is explicitly tested by some suites, including the GNU test suite.

Together with #5980 and #5989, this should make uutils pass the GNU test suite for shuf. Yay! :D

@sylvestre
Copy link
Contributor

please run rustfmt :)

@BenWiederhake
Copy link
Collaborator Author

Changes since last push:

  • Rebased on new main
  • Re-ran rustfmt, thanks @sylvestre! (I deactivated due to the rustc ICE a few days ago, and forgot to re-enable it)
  • Simplified the "no output" test, thanks @cakebaker!
  • Added a comment in the test, just to make extra clear that this is intentional.

@BenWiederhake
Copy link
Collaborator Author

Changes since last push:

  • Added "unwritable" to the cspell-ignore header.
  • test_cp::test_cp_arg_interactive_update flaked. No action taken.

This is explicitly tested by some suites, including the GNU test suite.
@BenWiederhake
Copy link
Collaborator Author

Changes since last push:

  • Rebased on current main
  • Simplified a few tests by calling .no_output(). Thanks @cakebaker!
  • Split test_zero_head_count_file_touch_output into three tests: Negative (tries to write to unwritable path), positive (new file created), another positive (touches existing file). Thanks @cakebaker!

@cakebaker cakebaker merged commit 5a2e0c7 into uutils:main Feb 23, 2024
62 checks passed
@cakebaker
Copy link
Contributor

Good job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants