Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp --link: don't fail if destination is hardlink to source #5484

Merged
merged 1 commit into from
Dec 26, 2023
Merged

cp --link: don't fail if destination is hardlink to source #5484

merged 1 commit into from
Dec 26, 2023

Conversation

cakebaker
Copy link
Contributor

With this PR, cp --link no longer shows a "same file" error if the destination is a hardlink to the source.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

GNU testsuite comparison:

GNU test failed: tests/cp/link-heap. tests/cp/link-heap is passing on 'main'. Maybe you have to rebase?

@cakebaker cakebaker marked this pull request as draft November 1, 2023 10:41
@sylvestre
Copy link
Contributor

@cakebaker still draft?

@sylvestre sylvestre force-pushed the cp_l_with_dest_hardlink_to_source branch from c11a239 to 4946478 Compare December 25, 2023 12:03
@cakebaker cakebaker marked this pull request as ready for review December 25, 2023 13:50
@cakebaker
Copy link
Contributor Author

As the GNU tests pass I think this PR shouldn't be a draft anymore.

@sylvestre
Copy link
Contributor

@cakebaker doesn't pass anymore it seems


2023-12-25T13:17:22.7079283Z mkdir: d00000000000000000000000001e+04: File exists
2023-12-25T13:17:22.7079415Z mkdir: d00000000000000000000000001e+04: File exists
2023-12-25T13:17:22.7079777Z link-heap.sh: set-up failure: 
2023-12-25T13:17:22.7079988Z ERROR tests/cp/link-heap.sh (exit status: 99)

sylvestre
sylvestre requested changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@cakebaker
Copy link
Contributor Author

I think it is an unrelated issue, it is also shown with other PRs.

@sylvestre sylvestre merged commit 167acb5 into uutils:main Dec 26, 2023
56 of 57 checks passed
@cakebaker cakebaker deleted the cp_l_with_dest_hardlink_to_source branch December 26, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre