Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stty: Support setting baud rate #5053

Merged
merged 1 commit into from
Jul 8, 2023
Merged

stty: Support setting baud rate #5053

merged 1 commit into from
Jul 8, 2023

Conversation

dezgeg
Copy link
Contributor

@dezgeg dezgeg commented Jul 7, 2023

Part of #3859.

@tertsdiepraam
Copy link
Member

Looks good! Do you think maybe we should give an error if an unsupported baud rate is given on the platforms where it's based on an enum?

@dezgeg
Copy link
Contributor Author

dezgeg commented Jul 8, 2023

It does eventually end up into the invalid argument case on Linux and give same error message as GNU does

stty: invalid argument '12345'

tertsdiepraam
tertsdiepraam approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine!

@tertsdiepraam tertsdiepraam merged commit 24c2743 into uutils:main Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dezgeg @tertsdiepraam