coreutils: fixed panic when multi-call binary has funny name #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name The multi-call `coreutils` binary starts by trying to convert its invocation path into a UTF-8 string, panicking if this doesn't work. This patch makes `coreutils` exit gracefully in this case.
|
Cool, thanks. Would it be possible to write a test to make sure we don't regress in the future ? |
|
To be honest, I'm not sure what test would be worth inserting here. As long as Any reasonable test would have to manipulate the host filesystem in odd ways, and would be unlikely to be very portable. I'll think about what might be done. |
|
Maybe an integration test that just calls the binary with invalid utf-8 in this file: https://github.com/uutils/coreutils/blob/main/tests/test_util_name.rs? Edit: Nevermind that's still difficult. |
|
Thanks! |
|
Thank you and sorry for the latency ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi-call
coreutilsbinary starts by trying to convert its invocation path into a UTF-8 string, panicking if this doesn't work.This patch makes
coreutilsexit gracefully in this case.