install: fix bug #1823

src/uu/install/src/install.rs

@@ -426,18 +426,25 @@ fn copy_files_into_dir(files: &[PathBuf], target_dir: &PathBuf, b: &Behavior) ->
 
     let mut all_successful = true;
     for sourcepath in files.iter() {
-        let targetpath = match sourcepath.as_os_str().to_str() {
-            Some(name) => target_dir.join(name),
-            None => {
-                show_error!(
-                    "cannot stat '{}': No such file or directory",
-                    sourcepath.display()
-                );
+        if !sourcepath.exists() {
+            show_error!(
+                "cannot stat '{}': No such file or directory",
+                sourcepath.display()
+            );
 
-                all_successful = false;
-                continue;
-            }
-        };
+            all_successful = false;
+            continue;
+        }
+
+        if sourcepath.is_dir() {
+            show_info!("omitting directory '{}'", sourcepath.display());
+            all_successful = false;
+            continue;
+        }
+
+        let mut targetpath = target_dir.clone().to_path_buf();
+        let filename = sourcepath.components().last().unwrap();
+        targetpath.push(filename);
 
         if copy(sourcepath, &targetpath, b).is_err() {
             all_successful = false;

tests/by-util/test_install.rs

@@ -358,3 +358,21 @@ fn test_install_target_file_dev_null() {
     ucmd.arg(file1).arg(file2).succeeds().no_stderr();
     assert!(at.file_exists(file2));
 }
+
+#[test]
+fn test_install_copy_file_leading_dot() {
+    let (at, mut ucmd) = at_and_ucmd!();
+    let dir1 = "test_install_target_new_file_dir_l";
+    let dir2 = "test_install_target_new_file_dir_m";
+    let file1 = "test_install_target_file_file_l1";
+
+    at.mkdir(dir1);
+    at.mkdir(dir2);
+    at.touch(&format!("{}/{}", dir1, file1));
+
+    ucmd.arg(format!("{}/{}", dir1, file1))
+        .arg(dir2)
+        .succeeds()
+        .no_stderr();
+    assert!(at.file_exists(&format!("{}/{}", dir2, file1)));
+}