add full uuid macro #1

mokeyish · 2018-05-04T16:39:13Z

It depend on ref const Uuid::from_uuid_bytes

The example

extern crate uuid;
extern crate uuid_macro;

use uuid::Uuid;

// if you want to create const uuid value,just enable nightly feature.
const CONST_UUID: Uuid = uuid!("936DA01F9ABD4d9d80C702AF85C822A8");

fn main() {
    let my_uuid = uuid!("936DA01F9ABD4d9d80C702AF85C822A8")
    println!("Parsed a version {} UUID.", my_uuid.get_version_num());
    println!("{}", my_uuid);
}

…re/uuid-macro

…/uuid-macro

kinggoesgaming · 2018-05-07T02:12:43Z

src/lib.rs

@@ -1,101 +1,57 @@
-#![recursion_limit="128"]
+extern crate uuid;
+pub use uuid::Uuid;


we can't have a pub export here...

kinggoesgaming · 2018-05-07T02:13:11Z

src/lib.rs

    }
-}
+}


newlines will be fixed by rustfmt so not a worry

kinggoesgaming · 2018-05-07T02:16:34Z

Cargo.toml


+[features]
+default = []
+nightly = []


kinggoesgaming · 2018-05-07T02:18:10Z

src/lib.rs


+    #[cfg(feature = "nightly")]


just use #[cfg(nightly)]

@kinggoesgaming Are you sure #[cfg(nightly)]really working? I create an new hello-word project with cargo new hello-world --bin, and modify main.rs :

fn main() { test(); } #[cfg(nightly)] fn test() { println!("nightly, Hello, world!"); } #[cfg(not(nightly))] fn test() { println!("not nightly, Hello, world!"); }

Run with command cargo +nightly run,It still prints not nightly, Hello, world!;

@kinggoesgaming yah he is right. I reproduced it here and I'm getting the same output

I guess it works only when you have a mod foo or extern crate.

Something funky is definitely going on... Imma fiddle around today on this

alright after going through the mighty google, I seems I was wrong. #[cfg(nightly)] was discussed at one point, however no resolution... This includes the mod foo

This needs resolution in a way that user does not have to explicitly provide the nightly feature gate. I will probably use a build script in combination with rustc_version for this

@mokeyish see uuid-rs/uuid#220

I think the same setup can be added here (perhaps as a separate PR that is merged before this PR)

@kinggoesgaming what's the issue with providing an explicit feature in order to enable an unstable nightly Rust feature?

proceed with the #[cfg(feature = "nightly")]

kinggoesgaming · 2018-05-07T02:27:13Z

src/lib.rs

+    {$literal:expr} => {
+        {
+            const BYTES: [u8; 16] = uuid_parts! {$literal};
+            $crate::Uuid::from_uuid_bytes(BYTES)


As it is clear that people need to depend on uuid, instead use:

{ use uuid; uuid::Uuid::from_uuid_bytes(BYTES) }

Dylan-DPC-zz · 2018-05-04T17:28:06Z

Cargo.toml

+[dependencies]
+uuid_macro_impl = { path = "./uuid_macro_impl"}
+proc-macro-hack = { version = "0.4"}
+uuid = { git = "https://github.com/mokeyish/uuid.git", branch = "master" }


why depend on the fork?

@Dylan-DPC Because this have't approved yet. Do you know why about this snapshot.

Yes i know. Just made that note so we remember to switch back to the crate once that is completed.

the PR has been merged, so update this...

Note that once we get [email protected] is released we update this again... (later)

Dylan-DPC-zz · 2018-05-07T05:05:28Z

uuid_macro_impl/Cargo.toml

@@ -0,0 +1,23 @@
+[package]
+authors = [
+    "Hunar Roop Kahlon <[email protected]>",


you forgot me 😆

218: Add const Uuid::from_uuid_bytes r=kinggoesgaming a=mokeyish  **I'm submitting a const Uuid::from_uuid_bytes for creating const uuid value.** [ref uuid_macro](uuid-rs/uuid_macro#1) - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description  # Motivation  # Tests  # Related Issue(s)  Co-authored-by: MOKEYISH <[email protected]> Co-authored-by: YISH <[email protected]>

kinggoesgaming · 2018-05-24T02:28:38Z

@mokeyish can you update the version of uuid?

mokeyish · 2018-05-24T02:57:09Z

@kinggoesgaming The uuid create has an error.The Cargo.toml used const_fn = ["nightly"],but the /src/lib.rs used const-fn. So it worked unexpectedly.

kinggoesgaming · 2018-05-24T04:08:33Z

Oh no that managed to slip through... @Dylan-DPC or me will get a new version released to fix that

kinggoesgaming · 2018-05-24T22:24:31Z

@mokeyish update to 0.6.5 uuid

mokeyish · 2018-05-25T10:10:15Z

bors r+

Dylan-DPC-zz · 2018-05-25T10:42:03Z

@mokeyish you can't r+ till all the changes were approved

Dylan-DPC-zz · 2018-05-25T12:36:57Z

~~@mokeyish can you change the code as per what is requested in the review first? We can't merge till then~~
ignore this

Dylan-DPC-zz · 2018-05-25T13:22:29Z

@kinggoesgaming your previous review looks outdated now. Can you dismiss it and rereview?

stale boi stale

kinggoesgaming · 2018-05-25T01:05:56Z

Cargo.toml

+[dependencies]
+uuid_macro_impl = { path = "./uuid_macro_impl"}
+proc-macro-hack = { version = "0.4"}
+uuid = { version = "0.6.5", features = ["const_fn"]}


can you add default-features = false here as well?

kinggoesgaming · 2018-05-26T00:18:11Z

bors r+

1: add full uuid macro r=kinggoesgaming a=mokeyish It depend on [ref const Uuid::from_uuid_bytes](uuid-rs/uuid#218) *The example* ```rust extern crate uuid; extern crate uuid_macro; use uuid::Uuid; // if you want to create const uuid value,just enable nightly feature. const CONST_UUID: Uuid = uuid!("936DA01F9ABD4d9d80C702AF85C822A8"); fn main() { let my_uuid = uuid!("936DA01F9ABD4d9d80C702AF85C822A8") println!("Parsed a version {} UUID.", my_uuid.get_version_num()); println!("{}", my_uuid); } ``` Co-authored-by: YISH <[email protected]> Co-authored-by: YISH <[email protected]> Co-authored-by: mokeyish <[email protected]>

bors · 2018-05-26T00:19:44Z

Build succeeded

continuous-integration/travis-ci/push

add full uuid macro

0d5053b

mokeyish mentioned this pull request May 4, 2018

Add const Uuid::from_uuid_bytes uuid-rs/uuid#218

Merged

4 tasks

mokeyish and others added 5 commits May 5, 2018 10:31

Merge remote-tracking branch 'origin/travis-nightly-patch' into featu…

5b2cbd6

…re/uuid-macro

Merge branch 'master' into feature/uuid-macro

9433143

fix doc test

ab2ea8d

Merge remote-tracking branch 'origin/feature/uuid-macro' into feature…

7593f3e

…/uuid-macro

fix doc test

c9c28da

mokeyish assigned Dylan-DPC-zz and kinggoesgaming May 5, 2018

kinggoesgaming suggested changes May 7, 2018

View reviewed changes

Cargo.toml Outdated

[features]

default = []

nightly = []

Copy link

Member

kinggoesgaming May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

kinggoesgaming suggested changes May 7, 2018

View reviewed changes

kinggoesgaming previously requested changes May 7, 2018

View reviewed changes

Dylan-DPC-zz reviewed May 7, 2018

View reviewed changes

mokeyish and others added 3 commits May 13, 2018 18:52

fix the ref repository

d534909

Merge branch 'master' into feature/uuid-macro

e70ceb3

fix doc test

91418ac

kinggoesgaming mentioned this pull request May 16, 2018

Introduce a const_fn feature gate uuid-rs/uuid#226

Closed

mokeyish added 3 commits May 25, 2018 08:17

Update uuid dependency version to 0.6.5

3b65cb3

fix unused_imports warning

4bcdd06

fix travis scripts.

68282fe

kinggoesgaming suggested changes May 25, 2018

View reviewed changes

add default-features = false to uuid.

cbeaefc

kinggoesgaming approved these changes May 26, 2018

View reviewed changes

bors bot merged commit cbeaefc into master May 26, 2018

kinggoesgaming deleted the feature/uuid-macro branch May 26, 2018 00:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add full uuid macro #1

add full uuid macro #1

mokeyish commented May 4, 2018 •

edited

Loading

kinggoesgaming May 7, 2018

kinggoesgaming May 7, 2018

Dylan-DPC-zz May 7, 2018

kinggoesgaming May 7, 2018

kinggoesgaming May 7, 2018

mokeyish May 7, 2018

Dylan-DPC-zz May 7, 2018

Dylan-DPC-zz May 7, 2018

kinggoesgaming May 7, 2018

kinggoesgaming May 7, 2018 •

edited

Loading

kinggoesgaming May 8, 2018

KodrAus May 9, 2018

kinggoesgaming May 11, 2018

kinggoesgaming May 7, 2018 •

edited

Loading

Dylan-DPC-zz May 4, 2018

mokeyish May 7, 2018

Dylan-DPC-zz May 7, 2018

kinggoesgaming May 11, 2018 •

edited

Loading

mokeyish May 11, 2018

Dylan-DPC-zz May 7, 2018

kinggoesgaming May 7, 2018

kinggoesgaming commented May 24, 2018

mokeyish commented May 24, 2018

kinggoesgaming commented May 24, 2018

kinggoesgaming commented May 24, 2018

mokeyish commented May 25, 2018

Dylan-DPC-zz commented May 25, 2018

Dylan-DPC-zz commented May 25, 2018 •

edited

Loading

Dylan-DPC-zz commented May 25, 2018

kinggoesgaming May 25, 2018

kinggoesgaming commented May 26, 2018

bors bot commented May 26, 2018

add full uuid macro #1

add full uuid macro #1

Conversation

mokeyish commented May 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kinggoesgaming May 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kinggoesgaming May 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kinggoesgaming May 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kinggoesgaming commented May 24, 2018

mokeyish commented May 24, 2018

kinggoesgaming commented May 24, 2018

kinggoesgaming commented May 24, 2018

mokeyish commented May 25, 2018

Dylan-DPC-zz commented May 25, 2018

Dylan-DPC-zz commented May 25, 2018 • edited Loading

Dylan-DPC-zz commented May 25, 2018

Choose a reason for hiding this comment

kinggoesgaming commented May 26, 2018

bors bot commented May 26, 2018

Build succeeded

mokeyish commented May 4, 2018 •

edited

Loading

kinggoesgaming May 7, 2018 •

edited

Loading

kinggoesgaming May 7, 2018 •

edited

Loading

kinggoesgaming May 11, 2018 •

edited

Loading

Dylan-DPC-zz commented May 25, 2018 •

edited

Loading