Allow v3, v4, v5 features on wasm32-unknown-unknown #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a feature
Description
The v3, v4, v5 features did not work on
wasm32-unknown-unknown
in a no_std context.For v3 and v5, the
md5
andsha1
crates are no_std if their default features are disabled, so they work onwasm32-unknown-unknown
.For v4,
getrandom
can work on any architecture if the root crate registers a custom implementation.This is not a breaking change, as the other architectures (including
stdweb
andwasm-bindgen
) are not impacted.Motivation
I wanted to use this crate (especially the v4 feature) on a
wasm32-unknown-unknown
context that does not havestdweb
norwasm-bindgen
.Tests
The test suite unfortunately does not run on
wasm32-unknown-unknown
.The v3, v4, v5 features work properly, as I was able to use them from a dependent crate.