-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unspecified direct object in README #454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Feb 15, 2020
454: Fix unspecified direct object in README r=Dylan-DPC a=cedric-h <!-- If this PR is a breaking change, ensure that you are opening it against the `breaking` branch. If the pull request is incomplete, prepend the Title with WIP: --> **I'm submitting a grammar fix for the README** # Description Previously, the README contained "They are particularly useful in distributed systems, *though can be used*..." To a native speaker, this sounds a little strange, whereas "They are particularly useful in distributed systems, though **they** can be used..." is clearer and more grammatically correct. # Motivation I'd like to make the README easier to understand # Tests I read it out loud and it sounded better and made more sense. # Related Issue(s) N/A Co-authored-by: Cedric Hutchings <[email protected]>
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 15, 2020
454: Fix unspecified direct object in README r=kinggoesgaming a=cedric-h <!-- If this PR is a breaking change, ensure that you are opening it against the `breaking` branch. If the pull request is incomplete, prepend the Title with WIP: --> **I'm submitting a grammar fix for the README** # Description Previously, the README contained "They are particularly useful in distributed systems, *though can be used*..." To a native speaker, this sounds a little strange, whereas "They are particularly useful in distributed systems, though **they** can be used..." is clearer and more grammatically correct. # Motivation I'd like to make the README easier to understand # Tests I read it out loud and it sounded better and made more sense. # Related Issue(s) N/A Co-authored-by: Cedric Hutchings <[email protected]>
HA! We forgot to review it |
kinggoesgaming
approved these changes
Feb 15, 2020
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 15, 2020
454: Fix unspecified direct object in README r=kinggoesgaming a=cedric-h <!-- If this PR is a breaking change, ensure that you are opening it against the `breaking` branch. If the pull request is incomplete, prepend the Title with WIP: --> **I'm submitting a grammar fix for the README** # Description Previously, the README contained "They are particularly useful in distributed systems, *though can be used*..." To a native speaker, this sounds a little strange, whereas "They are particularly useful in distributed systems, though **they** can be used..." is clearer and more grammatically correct. # Motivation I'd like to make the README easier to understand # Tests I read it out loud and it sounded better and made more sense. # Related Issue(s) N/A Co-authored-by: Cedric Hutchings <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a grammar fix for the README
Description
Previously, the README contained "They are particularly useful in distributed systems, though can be used..."
To a native speaker, this sounds a little strange, whereas "They are particularly useful in distributed systems, though they can be used..." is clearer and more grammatically correct.
Motivation
I'd like to make the README easier to understand
Tests
I read it out loud and it sounded better and made more sense.
Related Issue(s)
N/A