feat: add 8 bit-flags into script type args to control features #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flouse
previously approved these changes
Mar 20, 2024
jjyr
previously approved these changes
Mar 20, 2024
yangby-cryptape
force-pushed
the
feature/add-flags
branch
from
afd85a1 to
1d33d5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Bitcoin has a formula1 to calculate target difficulties.
But Bitcoin testnet has the following rule2:
So, if I want to use a same script to create both mainnet and testnet SPV instance on CKB, flags to control the checks are required.
Footnotes
What is the formula for difficulty? ↩
Differences between Mainnet and Testnet ↩