Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ソースが汚いのでなんとかする #1

Open
utubo opened this issue Aug 22, 2021 · 5 comments
Open

ソースが汚いのでなんとかする #1

utubo opened this issue Aug 22, 2021 · 5 comments

Comments

@utubo
Copy link
Owner

utubo commented Aug 22, 2021 •
edited
Loading

ヤバい
typoもある
@utubo
Copy link
Owner Author

utubo commented Aug 22, 2021 •
edited
Loading

  • 使ってない変数 -> fixed: aff83cb
const w = e3.target.width;
const h = e3.target.height;

utubo added a commit that referenced this issue Aug 24, 2021
@utubo
#1
de816c0
@utubo
Copy link
Owner Author

utubo commented Aug 24, 2021 •
edited
Loading

  • 画像読み込みの処理がスパゲッティでやばい
    • onloadのネストがやばい -> fixed: aff83cb
    • 変数名や関数名が適当すぎてやばい -> fixed: e0c9539 5432f1a

utubo added a commit that referenced this issue Aug 25, 2021
@utubo
#1
37993fc
utubo added a commit that referenced this issue Aug 25, 2021
@utubo
#1
2ad01f6
@utubo
Copy link
Owner Author

utubo commented Aug 26, 2021 •
edited
Loading

  • ディレクトリ構成やばい全部docsに入ってる
    (当初はsrcとtestとdocsにしてsrcから出来上がったものをdocsに入れる予定だった)

rootかdocsしか公開できないのでしかたない
Issueを発行してそっちで管理 #9

utubo added a commit that referenced this issue Aug 26, 2021
@utubo
#1
5f1ab28
utubo added a commit that referenced this issue Aug 27, 2021
@utubo
#1
aff83cb
utubo added a commit that referenced this issue Aug 27, 2021
@utubo
#1
e0c9539
utubo added a commit that referenced this issue Aug 27, 2021
@utubo
#1
5432f1a
@utubo
Copy link
Owner Author

utubo commented Aug 27, 2021 •
edited
Loading

  • 色の個別指定のソースがスパゲッティでやばい

utubo added a commit that referenced this issue Aug 27, 2021
@utubo
#1
f133e45
utubo added a commit that referenced this issue Aug 28, 2021
@utubo
#1
9ab1030
utubo pushed a commit that referenced this issue Aug 31, 2021
#1
db76fb2
utubo pushed a commit that referenced this issue Aug 31, 2021
#1
87b60a6
@utubo
Copy link
Owner Author

utubo commented Sep 22, 2021

  • HSLスライダーのソースぐちゃぐちゃでやばい

utubo added a commit that referenced this issue Sep 23, 2021
@utubo
#1
d494bf6
utubo added a commit that referenced this issue Sep 23, 2021
@utubo
#1
fce0633
utubo added a commit that referenced this issue Sep 23, 2021
@utubo
#1
bab0d79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@utubo