[SC-25] and [SC-26] User model updates and form updates #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +17,8 @@ class User(AbstractBaseUser, PermissionsMixin): | |||
| ) | |||
| first_name = models.CharField(_("first name"), max_length=150, blank=True) | |||
| last_name = models.CharField(_("last name"), max_length=150, blank=True) | |||
| phone_number = models.CharField(max_length=15, blank=True, null=True) | |||
| total_donations = models.DecimalField(max_digits=10, decimal_places=2, default=0.00) | |||
There was a problem hiding this comment.
I believe Joshua created a total_donations field already for one of his tickets so this might not be needed
|
|
||
| def validate(self, attrs): | ||
| if attrs.get("password1") != attrs.get("password2"): | ||
| raise serializers.ValidationError({"password": "Passwords do not match"}) | ||
|
|
||
| if not attrs.get("phone_number").isdigit() or len(attrs.get("phone_number")) < 10: |
There was a problem hiding this comment.
I have not used the react library here, but does the form validation in the frontend avoid dashes between numbers i.e 416-523-..... or can only raw numbers be put in?
| superuser = User.objects.create_superuser( | ||
| email="[email protected]", | ||
| password="adminpassword", | ||
| phone_number="+1987654321" |
There was a problem hiding this comment.
Shouldn't this test not be valid since it contains a non digit char (+) and also is longer than 10 chars? I'm more so asking because this is what would be restricted in practice with the existing serializer
| }; | ||
|
|
||
| useEffect(() => { | ||
| axios.get("https://ipapi.co/json/") |
VamsiGajjela
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User model should be updated now to have phone numbers as mandatory.
Tests ran: (check test file) and phone number appears in shell.
Forms should check for a valid phonenumber, email, names, and strong password (i made up the requirements for that one)/
Charity signup form shows errors "onChange" because it was annoying otherwise.
Register shows errors after sumbit. I can make both these forms have a consistent error display mode (idk what its called) if necessary.
Signup page i think should be validated on the backend?
Donate I thought we were "repurposing" so no i did not do that form.