Fix builds for cross-compilation with mingw #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per #631 (comment) my build wasn't broken to begin with, but you're right, my native Windows (AMD64) build doesn't start failing with this PR either. |
vlovich
changed the title
MarcusDunn
approved these changes
Feb 3, 2025
|
Thanks for the PR. I do not use windows, but if you want to setup a CI pipeline that will be the best way to make sure this stays fixed. (this is far from the first time windows support has been broken). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've confirmed this fixes the issue cross-compiling to Windows from Linux. I have a coworker who says their Windows native build is failing although in theory that shouldn't be this patch. Will investigate further next week but figured I'd put up a PR for discussion.
#631