Build for aarch64-linux-android #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusDunn
approved these changes
Dec 29, 2024
MarcusDunn
reviewed
Dec 29, 2024
| @@ -254,7 +263,7 @@ impl LlamaSampler { | |||
| .into_iter() | |||
| .map(|s| CString::new(s.as_ref()).unwrap()) | |||
| .collect(); | |||
| let mut seq_breaker_pointers: Vec<*const i8> = | |||
| let mut seq_breaker_pointers: Vec<*const CChar> = | |||
There was a problem hiding this comment.
Suggested change
| let mut seq_breaker_pointers: Vec<*const CChar> = | |
| let mut seq_breaker_pointers = |
MarcusDunn
reviewed
Dec 29, 2024
Comment on lines
+23
to
+31
| // this is needed for the dry sampler to typecheck on android | ||
| // ...because what is normally an i8, is an u8 | ||
| #[cfg(target_os = "android")] | ||
| type CChar = u8; | ||
|
|
||
| #[cfg(not(target_os = "android"))] | ||
| type CChar = i8; | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| // this is needed for the dry sampler to typecheck on android | |
| // ...because what is normally an i8, is an u8 | |
| #[cfg(target_os = "android")] | |
| type CChar = u8; | |
| #[cfg(not(target_os = "android"))] | |
| type CChar = i8; |
|
If the compiler can infer the type (and we avoid the platform-specific-types) that would be best. bindgen often also generates types that work accross platforms, unsure what it should be in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...does what it says on the tin.
We're building a Godot plugin, and people are requesting android support.
It seems to work for us:
nobodywho-ooo/nobodywho#67
There are two changes:
i8type that is anu8in the android NDK. I just set this type to be au8whe compiling for android.I'm not really an android dev, so not an expert on any of this. But it seems to work.