New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined behavior related to function pointer cast #184

Merged

utelle merged 1 commit into utelle:main from Koromix:fix_ub_function_pointer_cast

Dec 10, 2024

Contributor

Koromix commented Dec 10, 2024

Casting a function pointer to a different function pointer type is undefined behavior in C, and triggers UBSan as shown below:

This PR fixes this by changing the declaration of sqlite3mcFreeCodecParameterTable to take a void * pointer and avoid the cast entirely.


          Fix undefined behavior related to function pointer cast

d2964e5

Owner

utelle commented Dec 10, 2024

Thanks for reporting the issue and providing a fix.

utelle merged commit 08edcd9 into utelle:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet