Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API exports when building shared lib with CMake #125

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Add API exports when building shared lib with CMake #125

merged 3 commits into from
Nov 15, 2023

Conversation

Myroendan
Copy link
Contributor

Myroendan and others added 2 commits November 15, 2023 08:33
@Myroendan
Add API exports when building shared lib with CMake
a2a1540 
- Fixed issue utelle#123 - CMake: APIs not exported when building shared library
@Myroendan
Add Linux compatibility
6f64b9b
utelle
utelle requested changes Nov 15, 2023
View reviewed changes
Copy link
Owner

@utelle utelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, I'm fine with most changes. However, IMHO we will have to apply 2 additional (small) modifications:

  1. Add the linker flag -framework Security if the library is built for macOS (system name Darwin) - this is required due to commit fb0b979 in October.
  2. Remove sqlite3mc.def from the SQLITE3MC_DLLRES_SRCS file list. Now, that the export definition is defined, this file is no longer needed.

Could you please apply these changes? TIA.

@Myroendan
Update CMakeLists.txt
05d52bf 
- Add linker flag for macOS
- Fix linux export definition
- remove .def file from sources
utelle
utelle approved these changes Nov 15, 2023
View reviewed changes
Copy link
Owner

@utelle utelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes.

@utelle utelle merged commit d027b4f into utelle:main Nov 15, 2023
9 checks passed
@utelle utelle mentioned this pull request Nov 15, 2023
Closed
@Myroendan Myroendan deleted the add-shared-lib-exports branch November 24, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utelle utelle utelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Myroendan @utelle