Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

117 optimize task cleanup move worker finalization to c++ #141

Merged
merged 14 commits into from
Nov 1, 2023
Merged

117 optimize task cleanup move worker finalization to c++ #141

merged 14 commits into from
Nov 1, 2023

Conversation

ShreyaTalati
Copy link
Collaborator

@ShreyaTalati ShreyaTalati commented Oct 17, 2023 •
edited
Loading

This change moves task cleanup and task wait to C++ into a single function so that there is no GIL switching between theses two.

ShreyaTalati and others added 13 commits September 6, 2023 09:53
@ShreyaTalati ShreyaTalati linked an issue Oct 17, 2023 that may be closed by this pull request
Optimize Task Cleanup (Move worker finalization to C++) #117
Closed
@ShreyaTalati ShreyaTalati requested a review from wlruys October 17, 2023 22:19
@nicelhc13
Copy link
Contributor

nicelhc13 commented Oct 18, 2023 •
edited
Loading

Please merge this to dev branch, not main branch after Will approves this. Please describe what this optimization is shortly.

@ShreyaTalati ShreyaTalati changed the base branch from main to dev October 18, 2023 11:45
@ShreyaTalati ShreyaTalati merged commit cd15df4 into dev Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlruys wlruys wlruys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize Task Cleanup (Move worker finalization to C++)
3 participants
@ShreyaTalati @nicelhc13 @wlruys