Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#33 coroutine dispatchers di #52

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Feature/#33 coroutine dispatchers di #52

merged 6 commits into from
Dec 12, 2023

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Dec 12, 2023

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • core:android ๋ชจ๋“ˆ ์ƒ์„ฑ
  • dispatcher ํ•˜๋“œ ์ฝ”๋”ฉ ์ œ๊ฑฐ

๐ŸŒฑ PR ํฌ์ธํŠธ

  • dispatcher ์˜์กด์„ฑ ์ฃผ์ž… ๋ฐฉ๋ฒ• ํ•œ๋ฒˆ ์‚ดํŽด๋ด์ฃผ์„ธ์š”~

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@jinukeu jinukeu added enhancement New feature or request chore labels Dec 12, 2023
@jinukeu jinukeu requested review from lsakee and BEEEAM-J December 12, 2023 01:37
@jinukeu jinukeu self-assigned this Dec 12, 2023
BEEEAM-J
BEEEAM-J approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค~! ๐Ÿ‘๐Ÿ‘
ํ˜น์‹œ ๊ตฌํ˜„ํ•˜์‹œ๋ฉด์„œ ์ฐธ๊ณ ํ•˜์‹  ์ž๋ฃŒ ์žˆ๋‹ค๋ฉด ๊ณต์œ  ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค ๐Ÿ™

lsakee
lsakee approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@jinukeu
Copy link
Member Author

jinukeu commented Dec 12, 2023

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค~! ๐Ÿ‘๐Ÿ‘
ํ˜น์‹œ ๊ตฌํ˜„ํ•˜์‹œ๋ฉด์„œ ์ฐธ๊ณ ํ•˜์‹  ์ž๋ฃŒ ์žˆ๋‹ค๋ฉด ๊ณต์œ  ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค ๐Ÿ™

๊ด€๋ จ ์ด์Šˆ์— ์ฒจ๋ถ€๋˜์–ด์žˆ์–ด์šฉ!! (์ง€ํ•˜์ฒ ์ด๋ผ ์ฒจ๋ถ€๊ฐ€ ํž˜๋“œ๋„ค์š” ํ•˜ํ•ณ)

@jinukeu jinukeu merged commit 800c443 into develop Dec 12, 2023
1 check passed
@jinukeu jinukeu deleted the feature/#33-coroutine-dispatchers-di branch December 13, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BEEEAM-J BEEEAM-J BEEEAM-J approved these changes

@lsakee lsakee lsakee approved these changes

Assignees

@jinukeu jinukeu

Labels
chore enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore] Coroutine Dispatchers Di
3 participants
@jinukeu @lsakee @BEEEAM-J