Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/core UI #44

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Feature/core UI #44

merged 3 commits into from
Dec 5, 2023

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Dec 5, 2023

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • core:ui ๋ชจ๋“ˆ ์ถ”๊ฐ€, ์œ ์šฉํ•œ ํ™•์žฅ ํ•จ์ˆ˜ ์ถ”๊ฐ€

๐ŸŒฑ PR ํฌ์ธํŠธ

  • suwikiClickable์„ ์‚ฌ์šฉํ•˜์—ฌ throttle(์—ฐ์† ํด๋ฆญ ๋ฐฉ์ง€) ์ ์šฉํ•ด์ฃผ์„ธ์š”!
  • suwikiClickable ์œ„์ฃผ๋กœ ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@jinukeu jinukeu added the chore label Dec 5, 2023
@jinukeu jinukeu requested review from lsakee and BEEEAM-J December 5, 2023 07:11
@jinukeu jinukeu self-assigned this Dec 5, 2023
lsakee
lsakee reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์‹ญ๋‹ˆ๋‹ค!

core/ui/src/main/java/com/suwiki/core/ui/extension/Modifier.kt
onClick: (() -> Unit)?,
) = runIf(runIf) {
composed {
val multipleEventsCutter = remember { MultipleEventsCutter.get() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ ํ˜น์‹œ ์š”๋ถ€๋ถ„ rememberUpdateState๋กœ ์ตœ์‹ ์ƒํƒœ๋ฅผ ๊ฐ€์ ธ์˜ค๋Š” ์ฝ”๋“œ๋ฅผ ์ ์šฉํ•˜๋Š” ๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rememberUpdateState ๊ด€๋ จ ์ž๋ฃŒ๋ฅผ ๋ณด๊ณ  ์™”๋Š”๋ฐ์š”.
suwikiClickable์•ˆ์˜ multipleEventsCutter๋Š” ํ•˜์œ„๋กœ ๋‚ด๋ ค๊ฐ€์ง€ ์•Š๊ธฐ ๋•Œ๋ฌธ์— ๊ตณ์ด ์‹ถ์Šต๋‹ˆ๋‹ค. (์ œ๊ฐ€ ์ดํ•ดํ•œ ๋ฐ”๋กœ๋Š” remberUpdateState๋Š” ํ•˜๋‚˜์˜ ๊ฐ’์„ 2๊ณณ ์ด์ƒ์—์„œ rememberํ•  ๋•Œ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ ๊ฐ™๋„ค์š” ... !??)
remberUpdateState๋ฅผ ์ ์šฉํ•ด์•ผํ•˜๋Š” ์ด์œ ๊ฐ€ ๋ญ”์ง€ ๊ถ๊ธˆํ•ด์š”.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ ์ €๋Š” https://kotlinworld.com/256 ์š”๋ธ”๋กœ๊ทธ ๋ณด์•˜๋Š”๋ฐ ํ•˜์œ„๋กœ ๋‚ด๋ ค๊ฐ€๋Š” ์ค„ ์•Œ์•˜์Šต๋‹ˆ๋‹ค! ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ—‰ ์ฃ„์†กํ• ๊ฑด ์•„๋‹ˆ์ฃ ~!
๋•๋ถ„์— ํ•˜๋‚˜ ๋ฐฐ์› ์–ด์š” ๊ผผ๊ผผํ•œ ๋ฆฌ๋ทฐ ์ •๋ง ๊ฐ์‚ฌ๋“œ๋ ค์š” ใ…Žใ…Ž ๐Ÿ‘ ๐Ÿ‘

BEEEAM-J
BEEEAM-J approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค~! MultipleEventsCutter ๋ฐฐ์›Œ๊ฐ‘๋‹ˆ๋‹ค ๐Ÿ™‚๐Ÿ™‚

@jinukeu jinukeu merged commit 6760c45 into develop Dec 5, 2023
1 check passed
@jinukeu jinukeu deleted the feature/core-ui branch December 5, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsakee lsakee lsakee left review comments

@BEEEAM-J BEEEAM-J BEEEAM-J approved these changes

Assignees

@jinukeu jinukeu

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore] Create Core UI
3 participants
@jinukeu @lsakee @BEEEAM-J