Feature/chips label component #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinukeu
requested changes
Dec 4, 2023
...nsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiCheckedColorChip.kt
Outdated
Show resolved
Hide resolved
...nsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiCheckedColorChip.kt
Outdated
Show resolved
Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiContainedChip.kt
Outdated
Show resolved
Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiContainedChip.kt
Outdated
Show resolved
Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiContainedChip.kt
Outdated
Show resolved
Hide resolved
...esignsystem/src/main/java/com/suwiki/core/designsystem/component/chips/ui/theme/TestTheme.kt
Outdated
Show resolved
Hide resolved
...designsystem/src/main/java/com/suwiki/core/designsystem/component/chips/ui/theme/TestType.kt
Outdated
Show resolved
Hide resolved
core/designsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiColorChip.kt
Outdated
Show resolved
Hide resolved
core/designsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiColorChip.kt
Outdated
Show resolved
Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiContainedChip.kt
Outdated
Show resolved
Hide resolved
또 스크린샷 이렇게 감싸면 표 안에 넣을 수 있어요! |
|
코멘트 전부 반영하였습니다! |
jinukeu
requested changes
Dec 5, 2023
core/designsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiColorChip.kt
Outdated
Show resolved
Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiContainedChip.kt
Outdated
Show resolved
Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiContainedChip.kt
Outdated
Show resolved
Hide resolved
...esignsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiOutlinedChip.kt
Outdated
Show resolved
Hide resolved
...signsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiContainedChip.kt
Outdated
Show resolved
Hide resolved
...esignsystem/src/main/java/com/suwiki/core/designsystem/component/chips/SuwikiOutlinedChip.kt
Outdated
Show resolved
Hide resolved
|
코멘트 전부 반영했습니다~! |
jinukeu
reviewed
Dec 5, 2023
Comment on lines
27
to
31
| painter = if (isChecked) { | ||
| painterResource(id = R.drawable.ic_color_checked_chip) | ||
| } else { | ||
| painterResource(id = R.drawable.ic_color_chip) | ||
| }, |
There was a problem hiding this comment.
painter = painterResource(id = if(isChecked) R.drawable.ic_color_checked_chip else R.drawable.ic_color_chip),요렇게 안에 넣는거 안되나요!?
There was a problem hiding this comment.
잘 됩니다! 안에 넣으니까 보기 더 편한 거 같네요
가독성 더 신경 쓰면서 코드 짜겠습니다 ㅠㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
🌱 PR 포인트
📸 스크린샷
📮 관련 이슈