Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/suwiki server error handling #24

Merged
merged 15 commits into from
Oct 23, 2023

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Oct 23, 2023

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ์ˆ˜์œ„ํ‚ค ์„œ๋ฒ„์—์„œ ์ž‘์—…ํ•œ ์—๋Ÿฌ์— ๋งž๋Š” Exception์„ ๋‚ด๋ ค์ฃผ๊ฒŒ ์„ค์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ˆ˜์œ„ํ‚ค ์—๋Ÿฌ์ธ ๊ฒฝ์šฐ -> ์ˆ˜์œ„ํ‚ค ์—๋Ÿฌ์— ๋งž๋Š” Exception์„ ๋‚ด๋ ค์คŒ
  • ์ˆ˜์œ„ํ‚ค ์—๋Ÿฌ๊ฐ€ ์•„๋‹Œ ๊ฒฝ์šฐ -> ๊ธฐ์กด Http Status Code์— ๋งž๋Š” Exception์„ ๋‚ด๋ ค์คŒ

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

# Conflicts:
#	app-compose/build.gradle.kts
#	app-compose/src/main/java/com/kunize/uswtimetable/MainActivity.kt
#	core/database/src/main/java/com/suwiki/core/database/OpenMajorDatabase.kt
#	data/openmajor/build.gradle.kts
#	data/openmajor/src/main/java/com/suwiki/data/openmajor/datasource/LocalOpenMajorProviderDataSource.kt
#	data/openmajor/src/main/java/com/suwiki/data/openmajor/datasource/LocalOpenMajorStorageDataSource.kt
#	data/openmajor/src/main/java/com/suwiki/data/openmajor/datasource/RemoteOpenMajorDataSource.kt
#	local/openmajor/build.gradle.kts
#	local/openmajor/src/main/java/com/suwiki/local/openmajor/converter/OpenMajor.kt
#	local/openmajor/src/main/java/com/suwiki/local/openmajor/datasource/LocalOpenMajorProviderDataSourceImpl.kt
#	local/openmajor/src/main/java/com/suwiki/local/openmajor/datasource/LocalOpenMajorStorageDataSourceImpl.kt
#	local/openmajor/src/main/java/com/suwiki/local/openmajor/di/LocalDataSourceModule.kt
#	presentation/build.gradle.kts
#	remote/openmajor/src/main/java/com/suwiki/remote/openmajor/datasource/RemoteOpenMajorDataSourceImpl.kt
@jinukeu jinukeu added the enhancement New feature or request label Oct 23, 2023
@jinukeu jinukeu merged commit 243e1b6 into develop Oct 23, 2023
1 check passed
@jinukeu jinukeu deleted the refactor/suwiki-server-error-handling branch October 23, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suwiki ์„œ๋ฒ„ ์—๋Ÿฌ ์ฒ˜๋ฆฌ ๋กœ์ง ๊ตฌํ˜„
1 participant