-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: core:common -> domain:common #139
Conversation
Walkthrough์ด๋ฒ ์
๋ฐ์ดํธ๋ Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (11)
- domain/common/src/main/java/com/suwiki/domain/common/RunCatchingIgnoreCancelled.kt (1 hunks)
- domain/lectureevaluation/editor/build.gradle.kts (1 hunks)
- domain/lectureevaluation/my/build.gradle.kts (1 hunks)
- domain/lectureevaluation/viewerreporter/build.gradle.kts (1 hunks)
- domain/login/build.gradle.kts (1 hunks)
- domain/notice/build.gradle.kts (1 hunks)
- domain/openmajor/build.gradle.kts (1 hunks)
- domain/signup/build.gradle.kts (1 hunks)
- domain/timetable/build.gradle.kts (1 hunks)
- domain/user/build.gradle.kts (1 hunks)
- settings.gradle.kts (2 hunks)
Files skipped from review due to trivial changes (1)
- domain/common/src/main/java/com/suwiki/domain/common/RunCatchingIgnoreCancelled.kt
Additional comments not posted (10)
domain/openmajor/build.gradle.kts (1)
8-8
: ์ด ๋ณ๊ฒฝ ์ฌํญ์ PR์ ๋ชฉํ์ ๋ถํฉํฉ๋๋ค. ๋ชจ๋ ์ด๋ฆ์ดcore:common
์์domain:common
์ผ๋ก ๋ณ๊ฒฝ๋์์ต๋๋ค.domain/signup/build.gradle.kts (1)
8-8
: ์ด ๋ณ๊ฒฝ ์ฌํญ์ PR์ ๋ชฉํ์ ๋ถํฉํฉ๋๋ค. ๋ชจ๋ ์ด๋ฆ์ดcore:common
์์domain:common
์ผ๋ก ๋ณ๊ฒฝ๋์์ต๋๋ค.domain/lectureevaluation/editor/build.gradle.kts (1)
9-9
: ์ด ๋ณ๊ฒฝ ์ฌํญ์ PR์ ๋ชฉํ์ ๋ถํฉํฉ๋๋ค. ๋ชจ๋ ์ด๋ฆ์ดcore:common
์์domain:common
์ผ๋ก ๋ณ๊ฒฝ๋์์ต๋๋ค. ๊ทธ๋ฌ๋projects.core.model
์ ์ฌ์ฉ์ ํ์ธ์ด ํ์ํฉ๋๋ค.Verification successful
projects.core.model
์์กด์ฑ์ ์ฌ๋ฌ ๋ชจ๋์์ ์ผ๊ด๋๊ฒ ์ฌ์ฉ๋๊ณ ์์ผ๋ฉฐ, ์ด๋ ์๋๋ ๊ฒ์ผ๋ก ๋ณด์ ๋๋ค. ๋ฐ๋ผ์ ์ด ๋ณ๊ฒฝ ์ฌํญ์ ๋ฌธ์ ๊ฐ ์์ต๋๋ค.
remote/common/build.gradle.kts
local/user/build.gradle.kts
local/common/build.gradle.kts
local/openmajor/build.gradle.kts
local/login/build.gradle.kts
local/timetable/build.gradle.kts
domain/user/build.gradle.kts
domain/timetable/build.gradle.kts
domain/notice/build.gradle.kts
domain/login/build.gradle.kts
domain/lectureevaluation/viewerreporter/build.gradle.kts
domain/lectureevaluation/my/build.gradle.kts
domain/lectureevaluation/editor/build.gradle.kts
core/ui/build.gradle.kts
core/security/build.gradle.kts
core/designsystem/build.gradle.kts
core/android/build.gradle.kts
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `projects.core.model` in other modules. # Test: Search for the dependency usage. Expect: Consistent usage or planned refactoring. rg --type kotlin $'projects.core.model'Length of output: 1264
domain/lectureevaluation/my/build.gradle.kts (1)
9-9
: ์ด ๋ณ๊ฒฝ ์ฌํญ์ PR์ ๋ชฉํ์ ๋ถํฉํฉ๋๋ค. ๋ชจ๋ ์ด๋ฆ์ดcore:common
์์domain:common
์ผ๋ก ๋ณ๊ฒฝ๋์์ต๋๋ค. ๊ทธ๋ฌ๋projects.core.model
์ ์ฌ์ฉ์ ํ์ธ์ด ํ์ํฉ๋๋ค.domain/lectureevaluation/viewerreporter/build.gradle.kts (1)
9-9
: ์ด ๋ณ๊ฒฝ์ฌํญ์ ํ๋ก์ ํธ์ ๋ชจ๋ ๊ตฌ์กฐ๋ฅผ ๊ฐ์ ํ๊ณ , ๊ด์ฌ์ฌ์ ๋ถ๋ฆฌ๋ฅผ ๋ช ํํ ํ๋ ๋ฐ ๋์์ด ๋ฉ๋๋ค. ๋ชจ๋ ์ฐธ์กฐ๊ฐ ์๋ก์ด ๋ชจ๋ ์ด๋ฆ์ ๋ฐ์ํ๋๋ก ํ์ธํ์ธ์.domain/login/build.gradle.kts (1)
9-9
: ์ด ๋ณ๊ฒฝ์ ๋ชจ๋ ์ด๋ฆ์core:common
์์domain:common
์ผ๋ก ์ฌ๋ฐ๋ฅด๊ฒ ์ ๋ฐ์ดํธํฉ๋๋ค. ๋ชจ๋ ๊ฐ์ ์ข ์์ฑ์ด ์ฌ๋ฐ๋ฅด๊ฒ ์ ์ง๋๊ณ ์๋์ง ํ์ธํ์ธ์.domain/notice/build.gradle.kts (1)
9-9
: ์ฝ๋ ๊ตฌ์กฐ์ ์กฐ์ง์ ๊ฐ์ ํ๊ธฐ ์ํ ๋ชจ๋ ์ด๋ฆ ๋ณ๊ฒฝ์ด ๋ฐ์๋์์ต๋๋ค. ํ๋ก์ ํธ ์ ์ฒด์์ ์ผ๊ด์ฑ์ ์ ์งํ๋์ง ํ์ธํด์ผ ํฉ๋๋ค.domain/timetable/build.gradle.kts (1)
9-9
: ๋ชจ๋ ์ด๋ฆ์ดdomain:common
์ผ๋ก ๋ณ๊ฒฝ๋์ด ์ฝ๋์ ๊ตฌ์กฐ๊ฐ ๊ฐ์ ๋์์ต๋๋ค. ์ด ๋ณ๊ฒฝ์ด ๋ค๋ฅธ ๋ชจ๋๊ณผ์ ์ข ์์ฑ์ ์ํฅ์ ๋ฏธ์น์ง ์๋๋ก ์ฃผ์ํ์ธ์.domain/user/build.gradle.kts (1)
9-9
: ์ฝ๋ ๋ณ๊ฒฝ ์ฌํญ์ด ๋ชฉํ์ ์ผ์นํฉ๋๋ค.domain:common
๋ชจ๋์ด ์ ๋๋ก ์ค์ ๋์๋์ง ํ์ธํ์ญ์์ค.Verification successful
์ฝ๋ ๋ณ๊ฒฝ ์ฌํญ์ด ๋ชฉํ์ ์ผ์นํ๋ฉฐ
domain:common
๋ชจ๋์ด ์ ๋๋ก ์ค์ ๋๊ณ ์ฌ๋ฌ ํ์ผ์์ ์ฐธ์กฐ๋๊ณ ์์์ ํ์ธํ์ต๋๋ค.
domain/signup/build.gradle.kts
domain/user/build.gradle.kts
domain/timetable/build.gradle.kts
domain/openmajor/build.gradle.kts
domain/notice/build.gradle.kts
domain/login/build.gradle.kts
domain/lectureevaluation/my/build.gradle.kts
domain/lectureevaluation/viewerreporter/build.gradle.kts
domain/lectureevaluation/editor/build.gradle.kts
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new `domain:common` module is properly set up. # Test: Search for the `build.gradle.kts` file in the `domain:common` directory. Expect: It should exist and contain necessary configurations. fd 'build.gradle.kts' --exec cat {}Length of output: 25590
Script:
#!/bin/bash # Description: Search for references to `domain:common` across the repository to ensure it is correctly referenced. rg 'projects.domain.common'Length of output: 736
settings.gradle.kts (1)
77-77
: ์๋ก์ด ๋ชจ๋:domain:common
์ ํฌํจ์ด PR ๋ชฉํ์ ์ผ์นํฉ๋๋ค. ์ด์ :core:common
๋ชจ๋์ ๋ํ ๋ชจ๋ ์ฐธ์กฐ๊ฐ ์ ๊ฑฐ๋์๋์ง ํ์ธํ์ญ์์ค.Verification successful
์๋ก์ด ๋ชจ๋
:domain:common
์ ํฌํจ์ด PR ๋ชฉํ์ ์ผ์นํฉ๋๋ค. ์ด์ :core:common
๋ชจ๋์ ๋ํ ๋ชจ๋ ์ฐธ์กฐ๊ฐ ์ ๊ฑฐ๋์์ต๋๋ค.
settings.gradle.kts
ํ์ผ์์:domain:common
๋ชจ๋ ํฌํจ์ด ์ถ๊ฐ๋จ.- ์ฝ๋๋ฒ ์ด์ค์์
:core:common
์ ๋ํ ์ฐธ์กฐ๊ฐ ๋ชจ๋ ์ ๊ฑฐ๋จ.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all references to the old `:core:common` module are removed. # Test: Search for any remaining references to `:core:common`. Expect: No occurrences should be found. rg ':core:common'Length of output: 17
Script:
#!/bin/bash # Description: Verify that all references to the old `:core:common` module are removed. # Test: Search for any remaining references to `:core:common` in all files. Expect: No occurrences should be found. rg ':core:common' --hidden --glob '!.git/**'Length of output: 44
๐ฎ ๊ด๋ จ ์ด์
Summary by CodeRabbit
projects.core.common
์์projects.domain.common
์ผ๋ก ์ ๋ฐ์ดํธํ์์ต๋๋ค.settings.gradle.kts
ํ์ผ์์":core:common"
์ ์ ๊ฑฐํ๊ณ":domain:common"
์ ์ถ๊ฐํ์ฌ ๋ชจ๋ ๊ตฌ์ฑ์ ๋ณ๊ฒฝํ์์ต๋๋ค.