Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: core:network -> remote:common #137

Merged
merged 1 commit into from
Jun 19, 2024
Merged

refactor: core:network -> remote:common #137

merged 1 commit into from
Jun 19, 2024

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Jun 19, 2024

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

Summary by CodeRabbit

  • Refactor

    • ApiResult๊ฐ€ com.suwiki.core.network.retrofit์—์„œ com.suwiki.remote.common.retrofit๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
    • NormalRetrofit์ด NoAuthRetrofit์œผ๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
    • AuthRetrofit์ด com.suwiki.core.network.di์—์„œ com.suwiki.remote.common.di๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
  • Chores

    • settings.gradle.kts์—์„œ core:network ๋ชจ๋“ˆ์ด ์ œ๊ฑฐ๋˜๊ณ  remote:common ๋ชจ๋“ˆ์ด ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

@jinukeu jinukeu self-assigned this Jun 19, 2024
Copy link

coderabbitai bot commented Jun 19, 2024

Walkthrough

์ „์ฒด์ ์ธ ๋ณ€๊ฒฝ์€ core:network ๋ชจ๋“ˆ์˜ ์ฝ”๋“œ๋ฅผ remote:common ๋ชจ๋“ˆ๋กœ ์ด๋™ํ•˜์—ฌ, ์˜์กด์„ฑ ๋ฐ ํŒจํ‚ค์ง€ ๊ฒฝ๋กœ ์—…๋ฐ์ดํŠธ๋ฅผ ํฌํ•จํ•ฉ๋‹ˆ๋‹ค. ์ด์— ๋”ฐ๋ผ ๊ฐ API ํŒŒ์ผ ๋ฐ DI ๋ชจ๋“ˆ์˜ import ๋ฌธ์ด ์ˆ˜์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์„ค์ • ํŒŒ์ผ์—์„œ๋„ ๊ด€๋ จ ๋ชจ๋“ˆ์ด ์กฐ์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

Changes

ํŒŒ์ผ ๊ฒฝ๋กœ ๋ณ€๊ฒฝ ์š”์•ฝ
.../signup/api/SignUpApi.kt ApiResult import ๊ฒฝ๋กœ ์—…๋ฐ์ดํŠธ
.../signup/di/ApiModule.kt Retrofit ์˜์กด์„ฑ ์ฃผ์ž…์—์„œ NormalRetrofit์„ NoAuthRetrofit์œผ๋กœ ๋ณ€๊ฒฝ
.../timetable/api/OpenLectureApi.kt ApiResult import ๊ฒฝ๋กœ ์—…๋ฐ์ดํŠธ
.../timetable/di/ApiModule.kt Retrofit ์˜์กด์„ฑ ์ฃผ์ž…์—์„œ NormalRetrofit์„ NoAuthRetrofit์œผ๋กœ ๋ณ€๊ฒฝ
.../user/api/UserApi.kt ApiResult import ๊ฒฝ๋กœ ์—…๋ฐ์ดํŠธ
.../user/di/ApiModule.kt AuthRetrofit import ๊ฒฝ๋กœ ์—…๋ฐ์ดํŠธ
settings.gradle.kts core:network ๋ชจ๋“ˆ ์ œ๊ฑฐ ๋ฐ remote:common ๋ชจ๋“ˆ ์ถ”๊ฐ€

Assessment against linked issues

Objective Addressed Explanation
์ด๋™: core:network -> remote:common (#136) โœ…

๐Ÿ‡ ์ž‘์€ ํ† ๋ผ๊ฐ€ ์ฝ”๋“œ ์ˆฒ ์†์—์„œ,
๋ชจ๋“ˆ์„ ๋ฐ”๊พธ๋ฉฐ ์ถค์„ ์ถ˜๋Œ€.
network๊ฐ€ common์ด ๋˜์—ˆ๊ณ ,
API ๋“ค์€ ์ƒˆ ์˜ท์„ ์ž…์—ˆ์–ด์š”.
์šฐ๋ฆฌ๋Š” ํ•จ๊ป˜ ๋›ฐ๋†€๋ฉฐ,
๋” ๋‚˜์€ ์ฝ”๋“œ๋ฅผ ๊ฟˆ๊พผ๋Œ€์š”. ๐ŸŒŸ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range and nitpick comments (1)
remote/common/src/main/java/com/suwiki/remote/common/authenticator/TokenAuthenticator.kt (1)

Line range hint 1-42: ํ† ํฐ ์ธ์ฆ ํด๋ž˜์Šค๋Š” ๋งŒ๋ฃŒ๋œ ํ† ํฐ์„ ์ ์ ˆํžˆ ๊ฐ์ง€ํ•˜๊ณ  ์ƒˆ๋กœ๊ณ ์นจ์„ ์‹œ๋„ํ•ฉ๋‹ˆ๋‹ค. ์ฝ”๋ฃจํ‹ด๊ณผ ๋ฎคํ…์Šค๋ฅผ ์‚ฌ์šฉํ•œ ์Šค๋ ˆ๋“œ ์•ˆ์ „์„ฑ ์ฒ˜๋ฆฌ๋Š” ํ›Œ๋ฅญํ•ฉ๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ, ๋กœ๊น… ๋ฉ”์‹œ์ง€๋ฅผ ์ข€ ๋” ๋ช…ํ™•ํ•˜๊ฒŒ ํ‘œํ˜„ํ•  ํ•„์š”๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค.

- .d("TokenAuthenticator - ์ด๋ฏธ ํ† ํฐ์ด ๊ฐฑ์‹ ๋จ / ์ค‘๋‹จ๋œ API ์žฌ์š”์ฒญ")
+ .d("TokenAuthenticator - ํ† ํฐ์ด ์ด๋ฏธ ๊ฐฑ์‹ ๋˜์–ด ์ค‘๋‹จ๋œ API๋ฅผ ์žฌ์š”์ฒญํ•ฉ๋‹ˆ๋‹ค.")
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9b04af9 and 60ff079.

Files selected for processing (44)
  • build-logic/convention/src/main/java/RemoteConventionPlugin.kt (1 hunks)
  • gradle/libs.versions.toml (2 hunks)
  • remote/common/build.gradle.kts (2 hunks)
  • remote/common/src/main/AndroidManifest.xml (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/api/AuthApi.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/authenticator/TokenAuthenticator.kt (3 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/di/ApiModule.kt (2 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/di/Consts.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/di/NetworkModule.kt (3 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/di/Qualifier.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/di/RepositoryModule.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/interceptor/AuthenticationInterceptor.kt (2 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/model/TokenResponse.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/repository/AuthRepository.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/repository/AuthRepositoryImpl.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/ApiResult.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/ApiResultCallAdapter.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/Json.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/ResultCallAdapterFactory.kt (1 hunks)
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/SuwikiErrorResponse.kt (1 hunks)
  • remote/lectureevaluation/editor/src/main/java/com/suwiki/remote/lectureevaluation/editor/api/ExamEditorApi.kt (1 hunks)
  • remote/lectureevaluation/editor/src/main/java/com/suwiki/remote/lectureevaluation/editor/api/LectureEditorApi.kt (1 hunks)
  • remote/lectureevaluation/editor/src/main/java/com/suwiki/remote/lectureevaluation/editor/di/ApiModule.kt (1 hunks)
  • remote/lectureevaluation/my/src/main/java/com/suwiki/remote/lectureevaluation/my/api/ExamMyApi.kt (1 hunks)
  • remote/lectureevaluation/my/src/main/java/com/suwiki/remote/lectureevaluation/my/api/LectureMyApi.kt (1 hunks)
  • remote/lectureevaluation/my/src/main/java/com/suwiki/remote/lectureevaluation/my/di/ApiModule.kt (1 hunks)
  • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/api/ExamReportApi.kt (1 hunks)
  • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/api/ExamViewerApi.kt (1 hunks)
  • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/api/LectureReportApi.kt (1 hunks)
  • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/api/LectureViewerApi.kt (1 hunks)
  • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/di/ApiModule.kt (1 hunks)
  • remote/login/src/main/java/com/suwiki/remote/login/api/LoginApi.kt (1 hunks)
  • remote/login/src/main/java/com/suwiki/remote/login/di/ApiModule.kt (1 hunks)
  • remote/notice/src/main/java/com/suwiki/remote/notice/api/NoticeApi.kt (1 hunks)
  • remote/notice/src/main/java/com/suwiki/remote/notice/di/ApiModule.kt (2 hunks)
  • remote/openmajor/src/main/java/com/suwiki/remote/openmajor/api/MajorApi.kt (1 hunks)
  • remote/openmajor/src/main/java/com/suwiki/remote/openmajor/di/ApiModule.kt (1 hunks)
  • remote/signup/src/main/java/com/suwiki/remote/signup/api/SignUpApi.kt (1 hunks)
  • remote/signup/src/main/java/com/suwiki/remote/signup/di/ApiModule.kt (2 hunks)
  • remote/timetable/src/main/java/com.suwiki.remote.timetable/api/OpenLectureApi.kt (1 hunks)
  • remote/timetable/src/main/java/com.suwiki.remote.timetable/di/ApiModule.kt (2 hunks)
  • remote/user/src/main/java/com/suwiki/remote/user/api/UserApi.kt (1 hunks)
  • remote/user/src/main/java/com/suwiki/remote/user/di/ApiModule.kt (1 hunks)
  • settings.gradle.kts (2 hunks)
Files skipped from review due to trivial changes (15)
  • build-logic/convention/src/main/java/RemoteConventionPlugin.kt
  • remote/common/src/main/AndroidManifest.xml
  • remote/common/src/main/java/com/suwiki/remote/common/di/Consts.kt
  • remote/common/src/main/java/com/suwiki/remote/common/di/Qualifier.kt
  • remote/common/src/main/java/com/suwiki/remote/common/di/RepositoryModule.kt
  • remote/common/src/main/java/com/suwiki/remote/common/model/TokenResponse.kt
  • remote/common/src/main/java/com/suwiki/remote/common/repository/AuthRepository.kt
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/ApiResult.kt
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/ApiResultCallAdapter.kt
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/Json.kt
  • remote/common/src/main/java/com/suwiki/remote/common/retrofit/SuwikiErrorResponse.kt
  • remote/lectureevaluation/my/src/main/java/com/suwiki/remote/lectureevaluation/my/api/ExamMyApi.kt
  • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/api/ExamViewerApi.kt
  • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/di/ApiModule.kt
  • settings.gradle.kts
Additional comments not posted (39)
remote/common/src/main/java/com/suwiki/remote/common/di/ApiModule.kt (1)

17-17: @NoAuthRetrofit ์• ๋…ธํ…Œ์ด์…˜์„ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์ด ์ ์ ˆํ•œ์ง€ ํ™•์ธํ•˜์„ธ์š”. AuthApi๋Š” ์ธ์ฆ์ด ํ•„์š”ํ•œ API๋กœ ๋ณด์ด๋ฏ€๋กœ @AuthRetrofit๊ฐ€ ๋” ์ ํ•ฉํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

remote/signup/src/main/java/com/suwiki/remote/signup/di/ApiModule.kt (1)

16-16: @NoAuthRetrofit ์• ๋…ธํ…Œ์ด์…˜ ์‚ฌ์šฉ์ด ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค. ํšŒ์›๊ฐ€์ž… API๋Š” ์ผ๋ฐ˜์ ์œผ๋กœ ์‚ฌ์ „ ์ธ์ฆ์ด ํ•„์š”ํ•˜์ง€ ์•Š๊ธฐ ๋•Œ๋ฌธ์ž…๋‹ˆ๋‹ค.

remote/user/src/main/java/com/suwiki/remote/user/di/ApiModule.kt (1)

3-3: @AuthRetrofit ์• ๋…ธํ…Œ์ด์…˜ ์‚ฌ์šฉ์ด ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค. ์‚ฌ์šฉ์ž ๊ด€๋ จ API๋Š” ์ผ๋ฐ˜์ ์œผ๋กœ ์ธ์ฆ์ด ํ•„์š”ํ•˜๊ธฐ ๋•Œ๋ฌธ์ž…๋‹ˆ๋‹ค.

remote/timetable/src/main/java/com.suwiki.remote.timetable/di/ApiModule.kt (2)

3-3: NoAuthRetrofit์œผ๋กœ์˜ ๋ณ€๊ฒฝ์€ ์ด ๋ชจ๋“ˆ์˜ Retrofit ์ข…์†์„ฑ์„ ๊ฐฑ์‹ ํ•˜๋Š” ๋ฐ ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค. ๋ณ€๊ฒฝ ์‚ฌํ•ญ์— ๋ฌธ์ œ๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค.


16-16: OpenLectureApi๋ฅผ ์ œ๊ณตํ•˜๋Š” ํ•จ์ˆ˜์˜ ์‹œ๊ทธ๋‹ˆ์ฒ˜ ๋ณ€๊ฒฝ์€ ์ ์ ˆํ•˜๋ฉฐ, ์ฃผ์„ ๋ณ€๊ฒฝ์ด ์—†๋Š” ๊ฒƒ์€ ํ•จ์ˆ˜์˜ ๋ช…ํ™•์„ฑ์„ ์œ ์ง€ํ•˜๋Š” ๋ฐ ๋„์›€์ด ๋ฉ๋‹ˆ๋‹ค. ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์Šน์ธํ•ฉ๋‹ˆ๋‹ค.

remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/api/LectureReportApi.kt (1)

3-3: ApiResult์˜ ์ž„ํฌํŠธ ๊ฒฝ๋กœ ๋ณ€๊ฒฝ์€ ๋ชจ๋“ˆ ๋ฆฌํŒฉํ† ๋ง์˜ ์ผํ™˜์œผ๋กœ ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค. ๋ฌธ์ œ๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค.

remote/login/src/main/java/com/suwiki/remote/login/di/ApiModule.kt (1)

3-3: AuthRetrofit์˜ ์ž„ํฌํŠธ ๊ฒฝ๋กœ ๋ณ€๊ฒฝ์€ ์ƒˆ๋กœ์šด ๋ชจ๋“ˆ ๊ตฌ์กฐ์— ๋งž๊ฒŒ ์กฐ์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์€ ์ ์ ˆํ•˜๋ฉฐ ๋ฌธ์ œ๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค.

remote/openmajor/src/main/java/com/suwiki/remote/openmajor/di/ApiModule.kt (1)

3-3: AuthRetrofit์˜ ์ž„ํฌํŠธ ๊ฒฝ๋กœ ๋ณ€๊ฒฝ์€ ์ƒˆ๋กœ์šด ๋ชจ๋“ˆ ๊ตฌ์กฐ์— ๋งž๊ฒŒ ์กฐ์ •๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์€ ์ ์ ˆํ•˜๋ฉฐ ๋ฌธ์ œ๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค.

remote/timetable/src/main/java/com.suwiki.remote.timetable/api/OpenLectureApi.kt (1)

3-3: ์ˆ˜์ž… ๋ณ€๊ฒฝ ์Šน์ธ.

remote/notice/src/main/java/com/suwiki/remote/notice/di/ApiModule.kt (1)

3-3: ์ˆ˜์ž… ๋ฐ ํ•จ์ˆ˜ ์„œ๋ช… ๋ณ€๊ฒฝ ์Šน์ธ.

Also applies to: 18-18

Verification successful

NoAuthRetrofit์ด ํ”„๋กœ์ ํŠธ ๋‚ด์—์„œ ์ œ๋Œ€๋กœ ๊ตฌ์„ฑ๋˜๊ณ  ์ผ๊ด€๋˜๊ฒŒ ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ๋‹ค์Œ ํŒŒ์ผ์—์„œ ์ด๋ฅผ ํ™•์ธํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค:

  • remote/common/src/main/java/com/suwiki/remote/common/di/NetworkModule.kt
  • remote/timetable/src/main/java/com.suwiki.remote.timetable/di/ApiModule.kt
  • remote/signup/src/main/java/com/suwiki/remote/signup/di/ApiModule.kt
  • remote/notice/src/main/java/com/suwiki/remote/notice/di/ApiModule.kt
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Ensure NoAuthRetrofit is correctly configured in the project.
# Test: Search for NoAuthRetrofit configuration.
rg --type kotlin $'NoAuthRetrofit'

Length of output: 1266

remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/api/ExamReportApi.kt (1)

3-3: ์ˆ˜์ž… ๋ณ€๊ฒฝ ์Šน์ธ.

remote/lectureevaluation/my/src/main/java/com/suwiki/remote/lectureevaluation/my/api/LectureMyApi.kt (1)

3-3: ์ˆ˜์ž… ๋ณ€๊ฒฝ ์Šน์ธ.

remote/lectureevaluation/my/src/main/java/com/suwiki/remote/lectureevaluation/my/di/ApiModule.kt (2)

3-3: ์ˆ˜์ •๋œ import ๊ฒฝ๋กœ๊ฐ€ ์ ์ ˆํ•˜๊ฒŒ ์—…๋ฐ์ดํŠธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. AuthRetrofit ์–ด๋…ธํ…Œ์ด์…˜์„ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์ด ์ ํ•ฉํ•œ์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.


Line range hint 10-10: @AuthRetrofit ์–ด๋…ธํ…Œ์ด์…˜์„ ์‚ฌ์šฉํ•˜์—ฌ ์˜์กด์„ฑ ์ฃผ์ž…์ด ์ผ๊ด€์„ฑ ์žˆ๊ฒŒ ๊ด€๋ฆฌ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ๋‹ค๋ฅธ ๋ชจ๋“ˆ์— ์˜ํ–ฅ์„ ๋ฏธ์น˜์ง€ ์•Š๋Š”์ง€ ํ™•์ธํ•˜๋Š” ๊ฒƒ์ด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค.

Also applies to: 12-12

Verification successful

@AuthRetrofit ์–ด๋…ธํ…Œ์ด์…˜์ด ํ”„๋กœ์ ํŠธ ์ „๋ฐ˜์—์„œ ์ผ๊ด€๋˜๊ฒŒ ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ๋‹ค๋ฅธ ๋ชจ๋“ˆ์—์„œ๋„ ๋™์ผํ•˜๊ฒŒ ์ ์šฉ๋˜๊ณ  ์žˆ์–ด, ์˜์กด์„ฑ ์ฃผ์ž…์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ๊ด€๋ฆฌ๋˜๊ณ  ์žˆ์Œ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

  • @AuthRetrofit ์–ด๋…ธํ…Œ์ด์…˜์ด ๋‹ค์Œ ํŒŒ์ผ๋“ค์—์„œ ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค:
    • remote/common/src/main/java/com/suwiki/remote/common/di/NetworkModule.kt
    • remote/user/src/main/java/com/suwiki/remote/user/di/ApiModule.kt
    • remote/openmajor/src/main/java/com/suwiki/remote/openmajor/di/ApiModule.kt
    • remote/login/src/main/java/com/suwiki/remote/login/di/ApiModule.kt
    • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/di/ApiModule.kt
    • remote/lectureevaluation/my/src/main/java/com/suwiki/remote/lectureevaluation/my/di/ApiModule.kt
    • remote/lectureevaluation/editor/src/main/java/com/suwiki/remote/lectureevaluation/editor/di/ApiModule.kt
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that the `@AuthRetrofit` annotation is consistently used across the project.

# Test: Search for the usage of `@AuthRetrofit` annotation.
rg --type kotlin $'@AuthRetrofit'

Length of output: 2049

remote/lectureevaluation/editor/src/main/java/com/suwiki/remote/lectureevaluation/editor/di/ApiModule.kt (2)

3-3: ๋™์ผํ•œ AuthRetrofit ์–ด๋…ธํ…Œ์ด์…˜์ด ์‚ฌ์šฉ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ์–ด๋…ธํ…Œ์ด์…˜์˜ ์ผ๊ด€๋œ ์‚ฌ์šฉ์€ ์ฝ”๋“œ์˜ ์œ ์ง€๋ณด์ˆ˜๋ฅผ ์šฉ์ดํ•˜๊ฒŒ ํ•ฉ๋‹ˆ๋‹ค.


Line range hint 10-10: API ์˜์กด์„ฑ ์ฃผ์ž…์ด ์ผ๊ด€๋˜๊ฒŒ ๊ด€๋ฆฌ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ๋‹ค๋ฅธ ๋ชจ๋“ˆ์—์„œ๋„ ๋™์ผํ•œ ๋ฐฉ์‹์œผ๋กœ ๊ด€๋ฆฌ๋˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

Also applies to: 12-12

Verification successful

API ์˜์กด์„ฑ ์ฃผ์ž…์ด ์ผ๊ด€๋˜๊ฒŒ ๊ด€๋ฆฌ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. @AuthRetrofit ์• ๋…ธํ…Œ์ด์…˜์ด ๋‹ค์–‘ํ•œ ๋ชจ๋“ˆ์—์„œ ์ผ๊ด€๋˜๊ฒŒ ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์Œ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

  • remote/user/src/main/java/com/suwiki/remote/user/di/ApiModule.kt
  • remote/common/src/main/java/com/suwiki/remote/common/di/NetworkModule.kt
  • remote/login/src/main/java/com/suwiki/remote/login/di/ApiModule.kt
  • remote/openmajor/src/main/java/com/suwiki/remote/openmajor/di/ApiModule.kt
  • remote/lectureevaluation/editor/src/main/java/com/suwiki/remote/lectureevaluation/editor/di/ApiModule.kt
  • remote/lectureevaluation/my/src/main/java/com/suwiki/remote/lectureevaluation/my/di/ApiModule.kt
  • remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/di/ApiModule.kt
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Ensure consistent use of `@AuthRetrofit` across different modules.

# Test: Search for the usage of `@AuthRetrofit` annotation.
rg --type kotlin $'@AuthRetrofit'

Length of output: 2049

remote/common/build.gradle.kts (2)

9-9: ๋„ค์ž„์ŠคํŽ˜์ด์Šค๊ฐ€ ์ ์ ˆํ•˜๊ฒŒ ์„ค์ •๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์ด ํ”„๋กœ์ ํŠธ์˜ ๋‹ค๋ฅธ ๋ถ€๋ถ„์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

Verification successful

๋„ค์ž„์ŠคํŽ˜์ด์Šค com.suwiki.remote.common์ด ๋‹ค๋ฅธ ๋„ค์ž„์ŠคํŽ˜์ด์Šค์™€ ์ถฉ๋Œํ•˜์ง€ ์•Š๋Š” ๊ฒƒ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์ด ํ”„๋กœ์ ํŠธ์˜ ๋‹ค๋ฅธ ๋ถ€๋ถ„์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

  • remote/common/build.gradle.kts: namespace = "com.suwiki.remote.common"
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that the new namespace does not conflict with existing namespaces in the project.

# Test: Search for namespace declarations across the project.
rg --type kotlin $'namespace ='

Length of output: 3184


13-13: buildConfigField๋ฅผ ํ†ตํ•ด ํ™˜๊ฒฝ์— ๋”ฐ๋ผ ๋‹ค๋ฅธ BASE_URL์„ ์„ค์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค. ์ด ์„ค์ •์ด ์ ์ ˆํ•˜๊ฒŒ ์ ์šฉ๋˜์—ˆ๋Š”์ง€ ํ…Œ์ŠคํŠธ๋ฅผ ํ†ตํ•ด ํ™•์ธํ•ด๋ณด์„ธ์š”.

Also applies to: 17-17

Verification successful

buildConfigField๋ฅผ ํ†ตํ•ด ์„ค์ •๋œ BASE_URL์ด ์ ์ ˆํ•˜๊ฒŒ ์ ์šฉ๋˜์—ˆ๋Š”์ง€ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. build.gradle.kts ํŒŒ์ผ์—์„œ ๋‘ ๊ฐ€์ง€ BASE_URL ์„ค์ •์ด ํ™•์ธ๋˜์—ˆ์œผ๋ฉฐ, NetworkModule.kt ํŒŒ์ผ์—์„œ BuildConfig.BASE_URL์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์Œ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

  • remote/common/build.gradle.kts
    • buildConfigField("String", "BASE_URL", "String.valueOf(\"http://54.180.72.97:8080\")")
    • buildConfigField("String", "BASE_URL", "String.valueOf(\"https://api.suwiki.kr\")")
  • remote/common/src/main/java/com/suwiki/remote/common/di/NetworkModule.kt
    • .baseUrl(BuildConfig.BASE_URL)
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that the BASE_URL is correctly applied in different build environments.

# Test: Search for BASE_URL configurations in the project.
rg --type kotlin $'BASE_URL'

Length of output: 492



Script:

#!/bin/bash
# Description: Verify the BASE_URL configurations in build.gradle.kts

# Check the build.gradle.kts file for BASE_URL configurations
rg 'buildConfigField\("String", "BASE_URL", "String.valueOf\("' --context 3

# Check the usage of BASE_URL in NetworkModule.kt
rg 'BuildConfig.BASE_URL' --context 3

Length of output: 1696



Script:

#!/bin/bash
# Description: Verify the BASE_URL configurations in build.gradle.kts

# Check the build.gradle.kts file for BASE_URL configurations
rg 'buildConfigField\("String", "BASE_URL", "String.valueOf\("' --context 3

# Check the usage of BASE_URL in NetworkModule.kt
rg 'BuildConfig.BASE_URL' --context 3

Length of output: 1696

remote/common/src/main/java/com/suwiki/remote/common/interceptor/AuthenticationInterceptor.kt (2)

1-1: ํŒจํ‚ค์ง€์™€ import ๊ฒฝ๋กœ๊ฐ€ ์ ์ ˆํ•˜๊ฒŒ ์—…๋ฐ์ดํŠธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. AuthRepository์˜ accessToken์„ ์‚ฌ์šฉํ•˜๋Š” ๋ฐฉ์‹์ด ์ ์ ˆํ•œ์ง€ ๊ฒ€ํ† ํ•ด์ฃผ์„ธ์š”.

Also applies to: 3-5


19-19: addHeader๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์ธ์ฆ ํ—ค๋”๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์ด ์‹ค์ œ๋กœ ์ธ์ฆ ๊ณผ์ •์— ์˜ํ–ฅ์„ ์ฃผ๋Š”์ง€ ํ™•์ธํ•ด๋ณด์„ธ์š”.

Verification successful

addHeader ๋ฉ”์„œ๋“œ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์ธ์ฆ ํ—ค๋”๊ฐ€ ์ถ”๊ฐ€๋˜๋Š”์ง€ ํ™•์ธํ•œ ๊ฒฐ๊ณผ, AuthenticationInterceptor๊ฐ€ NetworkModule.kt ํŒŒ์ผ์—์„œ OkHttpClient์— ํ†ตํ•ฉ๋˜์–ด ์‚ฌ์šฉ๋˜๊ณ  ์žˆ์Œ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. ์ด๋Š” ์ธ์ฆ ํ—ค๋”๊ฐ€ ์‹ค์ œ๋กœ ์ธ์ฆ ๊ณผ์ •์— ์˜ํ–ฅ์„ ๋ฏธ์น  ๊ฐ€๋Šฅ์„ฑ์ด ๋†’์Œ์„ ์˜๋ฏธํ•ฉ๋‹ˆ๋‹ค.

  • AuthenticationInterceptor๋Š” NetworkModule.kt์—์„œ OkHttpClient์— addInterceptor ๋ฉ”์„œ๋“œ๋ฅผ ํ†ตํ•ด ์ถ”๊ฐ€๋ฉ๋‹ˆ๋‹ค.
  • ์ด๋กœ ์ธํ•ด AuthenticationInterceptor๊ฐ€ ์š”์ฒญ ์‹œ ํ—ค๋”๋ฅผ ์ถ”๊ฐ€ํ•˜๋Š” ์—ญํ• ์„ ํ•˜๊ฒŒ ๋ฉ๋‹ˆ๋‹ค.

ํ•ด๋‹น ๋ณ€๊ฒฝ์ด ์ธ์ฆ ๊ณผ์ •์— ์˜ํ–ฅ์„ ๋ฏธ์น˜๋Š” ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that the authentication header is correctly added and affects the authentication process.

# Test: Search for the usage of `addHeader` method in the project.
rg --type kotlin $'addHeader'

Length of output: 175



Script:

#!/bin/bash
# Description: Verify the integration of AuthenticationInterceptor in the codebase.

# Search for the usage of AuthenticationInterceptor in the project.
rg --type kotlin 'AuthenticationInterceptor'

Length of output: 649



Script:

#!/bin/bash
# Description: Inspect the integration of AuthenticationInterceptor in NetworkModule.kt.

# Extract relevant parts of NetworkModule.kt to see how AuthenticationInterceptor is integrated.
rg --type kotlin --context 10 'AuthenticationInterceptor' remote/common/src/main/java/com/suwiki/remote/common/di/NetworkModule.kt

Length of output: 1553

remote/signup/src/main/java/com/suwiki/remote/signup/api/SignUpApi.kt (2)

3-3: ๋ณ€๊ฒฝ๋œ ๋ชจ๋“ˆ ๊ตฌ์กฐ๋ฅผ ๋ฐ˜์˜ํ•˜์—ฌ import ๋ฌธ์ด ์—…๋ฐ์ดํŠธ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์€ PR์˜ ๋ชฉํ‘œ์™€ ์š”์•ฝ์— ์ผ์น˜ํ•ฉ๋‹ˆ๋‹ค.


Line range hint 9-17: API ๋ฉ”์„œ๋“œ๋“ค์ด ์ƒˆ๋กœ์šด import๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์—…๋ฐ์ดํŠธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. TODO ์ฃผ์„์— ๋”ฐ๋ฅด๋ฉด v2 API๋กœ์˜ ์—…๊ทธ๋ ˆ์ด๋“œ๊ฐ€ ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค. ์ด๋Š” ํ˜„์žฌ PR์˜ ๋ฒ”์œ„๋ฅผ ๋ฒ—์–ด๋‚ฉ๋‹ˆ๋‹ค.

remote/login/src/main/java/com/suwiki/remote/login/api/LoginApi.kt (2)

3-3: ๋ณ€๊ฒฝ๋œ ๋ชจ๋“ˆ ๊ตฌ์กฐ๋ฅผ ๋ฐ˜์˜ํ•˜์—ฌ import ๋ฌธ์ด ์—…๋ฐ์ดํŠธ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์€ ์ผ๊ด€์„ฑ์„ ์œ ์ง€ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.


Line range hint 9-21: API ๋ฉ”์„œ๋“œ๋“ค์ด ์ƒˆ๋กœ์šด import๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์—…๋ฐ์ดํŠธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. TODO ์ฃผ์„์— ๋”ฐ๋ฅด๋ฉด v2 API๋กœ์˜ ์—…๊ทธ๋ ˆ์ด๋“œ๊ฐ€ ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค. ์ด๋Š” ํ˜„์žฌ PR์˜ ๋ฒ”์œ„๋ฅผ ๋ฒ—์–ด๋‚ฉ๋‹ˆ๋‹ค.

remote/notice/src/main/java/com/suwiki/remote/notice/api/NoticeApi.kt (2)

3-3: ๋ณ€๊ฒฝ๋œ ๋ชจ๋“ˆ ๊ตฌ์กฐ๋ฅผ ๋ฐ˜์˜ํ•˜์—ฌ import ๋ฌธ์ด ์—…๋ฐ์ดํŠธ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์€ ์ผ๊ด€์„ฑ์„ ์œ ์ง€ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.


Line range hint 9-25: API ๋ฉ”์„œ๋“œ๋“ค์ด ์ƒˆ๋กœ์šด import๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์—…๋ฐ์ดํŠธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

remote/lectureevaluation/editor/src/main/java/com/suwiki/remote/lectureevaluation/editor/api/ExamEditorApi.kt (2)

3-3: ๋ณ€๊ฒฝ๋œ ๋ชจ๋“ˆ ๊ตฌ์กฐ๋ฅผ ๋ฐ˜์˜ํ•˜์—ฌ import ๋ฌธ์ด ์—…๋ฐ์ดํŠธ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์€ ์ผ๊ด€์„ฑ์„ ์œ ์ง€ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.


Line range hint 9-23: API ๋ฉ”์„œ๋“œ๋“ค์ด ์ƒˆ๋กœ์šด import๋ฅผ ์‚ฌ์šฉํ•˜๋„๋ก ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์—…๋ฐ์ดํŠธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. TODO ์ฃผ์„์— ๋”ฐ๋ฅด๋ฉด v2 API๋กœ์˜ ์—…๊ทธ๋ ˆ์ด๋“œ๊ฐ€ ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค. ์ด๋Š” ํ˜„์žฌ PR์˜ ๋ฒ”์œ„๋ฅผ ๋ฒ—์–ด๋‚ฉ๋‹ˆ๋‹ค.

remote/lectureevaluation/editor/src/main/java/com/suwiki/remote/lectureevaluation/editor/api/LectureEditorApi.kt (1)

3-3: APIResult์˜ ์ž„ํฌํŠธ ๊ฒฝ๋กœ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ƒˆ ๊ฒฝ๋กœ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ž‘๋™ํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

remote/user/src/main/java/com/suwiki/remote/user/api/UserApi.kt (1)

3-3: APIResult์˜ ์ž„ํฌํŠธ ๊ฒฝ๋กœ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ƒˆ ๊ฒฝ๋กœ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ž‘๋™ํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

remote/openmajor/src/main/java/com/suwiki/remote/openmajor/api/MajorApi.kt (1)

3-3: APIResult์˜ ์ž„ํฌํŠธ ๊ฒฝ๋กœ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ƒˆ ๊ฒฝ๋กœ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ž‘๋™ํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

remote/common/src/main/java/com/suwiki/remote/common/repository/AuthRepositoryImpl.kt (1)

4-7: ์ธ์ฆ ๊ด€๋ จ ๋ฆฌํฌ์ง€ํ† ๋ฆฌ์˜ ์ž„ํฌํŠธ ๊ฒฝ๋กœ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ƒˆ ๊ฒฝ๋กœ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ž‘๋™ํ•˜๋Š”์ง€ ํ™•์ธํ•˜๊ณ , onSuccess ๋ฐ onFailure ๋ฉ”์†Œ๋“œ๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์‚ฌ์šฉ๋˜์—ˆ๋Š”์ง€ ๊ฒ€ํ† ํ•˜์„ธ์š”.

remote/common/src/main/java/com/suwiki/remote/common/retrofit/ResultCallAdapterFactory.kt (1)

Line range hint 6-34: ์ด ํด๋ž˜์Šค๋Š” Retrofit์˜ CallAdapter ํŒฉํ† ๋ฆฌ๋ฅผ ํ™•์žฅํ•˜์—ฌ API ํ˜ธ์ถœ์˜ ๋ฐ˜ํ™˜ ์œ ํ˜•์— ๋”ฐ๋ผ ์ ์ ˆํ•œ CallAdapter ์ธ์Šคํ„ด์Šค๋ฅผ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค. ๋ฐ˜ํ™˜ ์œ ํ˜•์ด ParameterizedType์ด ์•„๋‹Œ ๊ฒฝ์šฐ, ์ ์ ˆํ•œ ์˜ˆ์™ธ ๋ฉ”์‹œ์ง€์™€ ํ•จ๊ป˜ IllegalArgumentException์„ ๋ฐœ์ƒ์‹œํ‚ค๋Š” ๊ฒƒ์€ ์ข‹์€ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ๋ฐฉ์‹์ž…๋‹ˆ๋‹ค.

remote/lectureevaluation/viewerreporter/src/main/java/com/suwiki/remote/lectureevaluation/viewerreporter/api/LectureViewerApi.kt (2)

3-3: ์ˆ˜์ •๋œ import ๋ฌธ์€ ๋ฆฌํŒฉํ† ๋ง๋œ ๋ชจ๋“ˆ ๊ตฌ์กฐ๋ฅผ ๋ฐ˜์˜ํ•ฉ๋‹ˆ๋‹ค. ์ ์ ˆํ•œ ๋ณ€๊ฒฝ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค.


Line range hint 15-39: API ๋ฉ”์†Œ๋“œ ์ •์˜๊ฐ€ ๋ช…ํ™•ํ•˜๋ฉฐ, ๋ฐ˜ํ™˜ ์œ ํ˜•์œผ๋กœ ์—…๋ฐ์ดํŠธ๋œ ApiResult๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์ผ๊ด€์„ฑ์„ ์œ ์ง€ํ•ฉ๋‹ˆ๋‹ค. ๊ธฐ๋ณธ ๋งค๊ฐœ๋ณ€์ˆ˜์™€ ๊ตฌ์กฐํ™”๋œ ์—”๋“œํฌ์ธํŠธ ๊ฒฝ๋กœ๊ฐ€ ์ž˜ ์ •์˜๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค.

remote/common/src/main/java/com/suwiki/remote/common/di/NetworkModule.kt (2)

Line range hint 28-76: OkHttpClient ์ธ์Šคํ„ด์Šค ์ œ๊ณต ๋ฉ”์†Œ๋“œ๋Š” ์ ์ ˆํ•œ ํƒ€์ž„์•„์›ƒ๊ณผ ์ธํ„ฐ์…‰ํ„ฐ๋ฅผ ์„ค์ •ํ•ฉ๋‹ˆ๋‹ค. @NoAuthOkHttpClient ๋ฐ @AuthOkHttpClient ์ฃผ์„์„ ์‚ฌ์šฉํ•˜์—ฌ ๋‹ค๋ฅธ ํด๋ผ์ด์–ธํŠธ ๊ตฌ์„ฑ์„ ๊ตฌ๋ถ„ํ•˜๋Š” ๊ฒƒ์€ ์ข‹์€ ์‹ค์Šต์ž…๋‹ˆ๋‹ค.


Line range hint 75-105: Retrofit ์ธ์Šคํ„ด์Šค ์ œ๊ณต ๋ฐฉ๋ฒ•์€ ์˜ฌ๋ฐ”๋ฅธ ๊ธฐ๋ณธ URL, ํด๋ผ์ด์–ธํŠธ ๋ฐ ๋ณ€ํ™˜๊ธฐ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ API ํ˜ธ์ถœ์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ํ˜•์‹ํ™”๋˜๊ณ  ์‹คํ–‰๋˜๋„๋ก ํ•ฉ๋‹ˆ๋‹ค.

gradle/libs.versions.toml (2)

194-194: ์ƒˆ๋กœ์šด androidx-junit ๋ฒˆ๋“ค์ด ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด ๋ณ€๊ฒฝ์ด ํ”„๋กœ์ ํŠธ ์„ค์ •์— ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ํ†ตํ•ฉ๋˜์—ˆ๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.


Line range hint 9-9: compose-bom ๋ฒ„์ „์ด ์—…๋ฐ์ดํŠธ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ƒˆ ๋ฒ„์ „์ด ๋‹ค๋ฅธ Compose ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์™€ ํ˜ธํ™˜๋˜๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.

@jinukeu jinukeu merged commit 46aff95 into develop Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] core:network -> remote:common
1 participant