10598 Bug: Case Deadlines Blocked Issues in West #5775
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mwindo
commented
Feb 13, 2025
| @@ -1411,14 +1411,14 @@ export class Case extends JoiValidationEntity { | |||
| * @param {object} caseDeadlines - the case deadlines | |||
| * @returns {Case} the updated case entity | |||
| */ | |||
| updateAutomaticBlocked({ caseDeadlines }) { | |||
| updateAutomaticBlocked({ hasCaseDeadline }: { hasCaseDeadline: boolean }) { | |||
There was a problem hiding this comment.
I changed caseDeadlines to hasCaseDeadline because 1) we don't actually need all of the case deadlines, 2) getting all of the case deadlines upon insert would have meant an extra db query following the upsert in createCaseDeadline.ts, and 3) passing in only a subset of deadlines (e.g., the case deadline upserted in createCaseDeadline.ts) seemed misleading to future devs.
…ocked indicator without needing a refresh for create case deadline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when creating or deleting a case deadline, we immediately thereafter re-fetch the case deadlines as part of
updateCaseAutomaticBlock. If we created/deleted the case deadline in the East and then are immediately reading from the West, the West might not yet have the update, which leads to the case not being properly blocked/unblocked.This PR rectifies the issue by passing in data that results from create/delete rather than re-fetching.