Remove app context creation intermediate branch to test 1737559059 #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mwindo
reviewed
Jan 23, 2025
web-api/src/genericHandler.test.ts
Outdated
| mockApplicationContext | ||
| .getPersistenceGateway() | ||
| .getMaintenanceMode.mockReturnValue({ current: false }); | ||
| getMaintenanceMode.mockReturnValue({ current: false }); |
There was a problem hiding this comment.
Very minor, but can we use mockResolvedValue?
There was a problem hiding this comment.
Absolutely! Remind me to tell you a funny story about this later.
Mwindo
reviewed
Jan 23, 2025
| pathParameters: { | ||
| docketNumber: '123-30', | ||
| key: '26c6a0e5-5d11-45f0-9904-04d103ada04f', | ||
| it('returns the document download URL in v1 format - when the document exists', async () => { |
There was a problem hiding this comment.
Probably missing something obvious, but why are we no longer checking the feature flag? Same thing in three other test files.
There was a problem hiding this comment.
The feature flag was never used as far as I could tell. On or off did not matter.
Change port 5000 to 4001 as 5000 is used by Apple Airplay Receiver
…eation-intermediate-branch-to-test-1737559059
Mwindo
approved these changes
Jan 23, 2025
zachrog
deleted the
remove-app-context-creation-intermediate-branch-to-test-1737559059
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.