Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devex: clear judgeUser state on logout #5685

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

Mwindo
Copy link
Contributor

@Mwindo Mwindo commented Jan 10, 2025

Currently, judgeUser is not cleared upon logging out. This can cause issues if a user (e.g., a test user) logs in as a judge, logs out, then logs in as a non-judge.

@Mwindo Mwindo added the to test label Jan 10, 2025
@Mwindo Mwindo marked this pull request as ready for review January 10, 2025 14:45
Copy link
Contributor

@TomElliottFlexion TomElliottFlexion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need a test before going to staging, nbd

@Mwindo
Copy link
Contributor Author

Mwindo commented Jan 10, 2025

Might need a test before going to staging, nbd

Yep, it will be! This was caught as part of 10491 and will be checked accordingly. We might tack it onto the 10491 staging PR, but since it is only tangentially related, it could also go out separately. In either case, I will document it.

@Mwindo Mwindo merged commit 01324fd into ustaxcourt:test Jan 11, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants