10416 bug - cold case report permissions for general user #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermissions with other internal users
akuny
changed the title
zachrog
approved these changes
Jul 23, 2024
TomElliottFlexion
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of this bug was that the
ROLE_PERMISSIONS.COLD_CASE_REPORTpermission was added to theallInternalUserPermissionsarray inauthorizationClientService.ts, but was not added to thegeneralUserPermissionsarray.After making this change, I observed that the only permission in
allInternalUserPermissionsthat thegeneralUserPermissionsarray did not include wasROLE_PERMISSIONS.SEND_RECEIVE_MESSAGES. Since the general user is an internal court role, I:ROLE_PERMISSIONS.SEND_RECEIVE_MESSAGESfromallInternalUserPermissionsROLE_PERMISSIONS.SEND_RECEIVE_MESSAGESto the permissions arrays that derive their base permissions fromallInternalUserPermissions.There is no longer any redundancy in the definition of the general court user's permissions.