10169: BUG: Numbered/Bulleted list formatting on Order Generator not displaying appropriately on Preview or after Save #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to test: #4134
Notes: react-quill uses quill, which is customizable using two methods: either passing a
formatsprop which enables or disables specific pre-configured styles, or by creating custom Blot Objects using parchment. Unfortunately, react-quill also uses custom classes and characters instead of standard html for ordered and unordered lists. It is not a true WIZIWIG editor. This in combination with the fact the theopen discsymbol is not an html character entity makes it difficult (impossible?) to modify quill to match current auto-generated order<ul>styling. Instead, the generated orders have been updated to match quill's standard bulleted list.Exporting quill styles inline with the generated html is also possible using quill-delta-to-html, but due the non-standard styling mentioned above as well as the fact that the delta produces standard nested
<ol>and<ul>tabs I felt it best to continue using standard css styling