Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Updates - October 23, 2023 #4133

Merged

Conversation

jasonfu9966
Copy link
Contributor

@jasonfu9966 jasonfu9966 commented Oct 26, 2023

updated minor versions
updated ECR image due to awscli version update
Successful migration

@jasonfu9966 jasonfu9966 added the dependencies Pull requests that update a dependency file label Oct 26, 2023
@jasonfu9966 jasonfu9966 marked this pull request as ready for review October 27, 2023 19:02
@TomElliottFlexion
Copy link
Contributor

Nice! Is the new ECR image on the Court lower account, too?

Copy link
Contributor

@rachelschneiderman rachelschneiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the reindex was manually approved. What was the underlying reason it wasn't going to auto-approve?

Copy link
Contributor

@rachelschneiderman rachelschneiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an update for the AWS provider used in our Terraform files?

@jasonfu9966
Copy link
Contributor Author

jasonfu9966 commented Oct 28, 2023

Nice! Is the new ECR image on the Court lower account, too?

I... believe so? I published the ECR image with the script we have and that should provide the image everywhere, right?

Looks like the reindex was manually approved. What was the underlying reason it wasn't going to auto-approve?

Yeah, I talked to Jim about this, and the way the wait-for script works, you have to manually approve the step if the destination table has more records than the source table. There was a discrepancy in the number of judges, which I believe is something you saw when you were updating dependencies last week.

Is there an update for the AWS provider used in our Terraform files?

There wasn't when I created the first PR, but I see there is one now. I could include that here or leave it. I'm open.

@TomElliottFlexion
Copy link
Contributor

Nice! Is the new ECR image on the Court lower account, too?

I... believe so? I published the ECR image with the script we have and that should provide the image everywhere, right?

It depends on which credentials are set while the script is run. It needs to be run once with Flexion creds (for exp envs) and once with USTC lower env creds (for test/staging). Once the image is built, you should just need to re-tag and re-push it using the other account. Happy to help

@jasonfu9966
Copy link
Contributor Author

Nice! Is the new ECR image on the Court lower account, too?

I... believe so? I published the ECR image with the script we have and that should provide the image everywhere, right?

It depends on which credentials are set while the script is run. It needs to be run once with Flexion creds (for exp envs) and once with USTC lower env creds (for test/staging). Once the image is built, you should just need to re-tag and re-push it using the other account. Happy to help

Thanks! We got this resolved, and I updated the documentation to be clearer about this.

@jimlerza jimlerza merged commit bc1656b into ustaxcourt:staging Oct 30, 2023
36 checks passed
@jasonfu9966 jasonfu9966 deleted the Dependency-updates-2023-oct-week-4 branch November 2, 2023 20:15
@jimlerza jimlerza mentioned this pull request Nov 2, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants