Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile resolution subcommand returns no error with invalid JSON and YAML profiles #216

Closed
aj-stein-nist opened this issue Oct 26, 2023 · 2 comments · Fixed by metaschema-framework/metaschema-java#41
Labels
bug Something isn't working
Milestone

Comments

@aj-stein-nist
Copy link
Collaborator

Describe the bug

When using a recent development snapshot of the oscal-cli with liboscal-java v3.0.2, writing tests for #178 uncovered that certain kinds of invalid JSON and YAML profiles can be resolved with output, but do not throw a relevant error like that of the XML profiles.

Who is the bug affecting?

Technical staff using oscal-cli to resolve JSON and YAML profiles.

What is affected by this bug?

Correct error reporting on invalid input profiles during profile resolution.

When does this occur?

Consistently under integration testing.

How do we replicate the issue?

(TBD: I will upload a modified copy of tests to demonstrate the error after finalizing the tests in the aforementioned branch.)

Expected behavior (i.e. solution)

The CLI will report an error and a relevant return code (ExitCode.PROCESSING_ERROR) like that of an invalid XML profile, caused by a ProfileResolutionException exception.

Other Comments

I will use this issue to report the problem, but it is not clear if the source of this issue is liboscal-java, oscal-cli code, or both. I will transfer accordingly once I have more details.

@aj-stein-nist aj-stein-nist added the bug Something isn't working label Oct 26, 2023
@aj-stein-nist aj-stein-nist moved this from Needs Triage to Todo in NIST OSCAL Work Board Jan 31, 2024
@aj-stein-nist
Copy link
Collaborator Author

This should be ready for fix once the next patch release comes through in liboscal-java and that dep gets updated here. Moving status from Needs Triage to To Do.

@aj-stein-nist aj-stein-nist added this to the Future milestone Feb 1, 2024
@aj-stein-nist
Copy link
Collaborator Author

I will have to add some relevant examples for unit/integration tests to work this, tentatively this week or next.

@aj-stein-nist aj-stein-nist modified the milestones: Future, Next Feb 5, 2024
david-waltermire added a commit to david-waltermire/metaschema-java that referenced this issue May 27, 2024
… returns the root node when getValue is called.
david-waltermire added a commit to metaschema-framework/metaschema-java that referenced this issue May 27, 2024
… returns the root node when getValue is called. (#41)
@github-project-automation github-project-automation bot moved this from Todo to Done in NIST OSCAL Work Board May 27, 2024
david-waltermire added a commit to GSA/metaschema-java that referenced this issue May 28, 2024
… returns the root node when getValue is called.
david-waltermire added a commit to GSA/metaschema-java that referenced this issue May 28, 2024
… returns the root node when getValue is called.
david-waltermire added a commit to GSA/metaschema-java that referenced this issue May 28, 2024
… returns the root node when getValue is called.
david-waltermire added a commit to GSA/metaschema-java that referenced this issue May 28, 2024
… returns the root node when getValue is called.
david-waltermire added a commit to GSA/metaschema-java that referenced this issue May 28, 2024
… returns the root node when getValue is called.
david-waltermire added a commit to GSA/metaschema-java that referenced this issue May 28, 2024
… returns the root node when getValue is called.
david-waltermire added a commit to GSA/metaschema-java that referenced this issue May 28, 2024
… returns the root node when getValue is called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant