Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide download button for folders #325

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Hide download button for folders #325

merged 2 commits into from
Mar 12, 2024

Conversation

chuanlin2018
Copy link
Collaborator

This check in fixed following issue:
Issue: In the file list, download button showed up for folders which should not.
The column title that sometime display "Status" and sometime "Access" was by design. The default name is "Status". But when access level is 'restricted public', it changes to "Access". Here is the code:
if(this.record['accessLevel'] === 'restricted public') {
this.checkAccessPageType();
this.cols[3]['header'] = "Access";
}
To test the app locally, set the following config in environment.ts:
useMetadataService: true,
useCustomizationService: true
And change data.nist.gov to testdata.nist.gov if necessary.

Test case:
http://localhost:4200/lps/mds2-2909 (in testdata.nist.gov)
http://localhost:4200/lps/mds2-2645 (in data.nist.gov)

@chuanlin2018 chuanlin2018 requested a review from RayPlante March 12, 2024 17:39
@RayPlante
Copy link
Collaborator

@chuanlin2018 (& @GRG2): I see. I don't remember what our reasoning was at the time, but it looks like we had some. I think, though now, now that we see it, we prefer "Access" across the board. Do you think you could make that change?

Meanwhile, I'm testing the download link removal for folders.

@chuanlin2018
Copy link
Collaborator Author

Sure.

@chuanlin2018
Copy link
Collaborator Author

Changed.

Copy link
Collaborator

@RayPlante RayPlante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both updates work as expected (see on testdata)

@RayPlante RayPlante merged commit 05772c5 into integration Mar 12, 2024
2 checks passed
@RayPlante RayPlante deleted the fix/download-btn branch March 12, 2024 19:10
@chuanlin2018
Copy link
Collaborator Author

Confirmed in testdata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants